From: Andrew Lunn <andrew@lunn.ch>
To: Russell King <rmk+kernel@armlinux.org.uk>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, Vivien Didelot <vivien.didelot@gmail.com>
Subject: Re: [PATCH net-next 7/8] net: dsa: mv88e6xxx: remove port_link_state functions
Date: Sat, 14 Mar 2020 22:29:24 +0100 [thread overview]
Message-ID: <20200314212924.GD8622@lunn.ch> (raw)
In-Reply-To: <E1jD3pm-0006Dx-Sz@rmk-PC.armlinux.org.uk>
On Sat, Mar 14, 2020 at 10:15:58AM +0000, Russell King wrote:
> The port_link_state method is only used by mv88e6xxx_port_setup_mac(),
> which is now only called during port setup, rather than also being
> called via phylink's mac_config method.
>
> Remove this now unnecessary optimisation, which allows us to remove the
> port_link_state methods as well.
>
> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2020-03-15 1:54 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-14 10:14 [PATCH REPOST net-next 0/8] net: dsa: improve serdes integration Russell King - ARM Linux admin
2020-03-14 10:15 ` [PATCH net-next 1/8] net: dsa: warn if phylink_mac_link_state returns error Russell King
2020-03-14 18:34 ` Andrew Lunn
2020-03-14 10:15 ` [PATCH net-next 2/8] net: dsa: mv88e6xxx: use BMCR definitions for serdes control register Russell King
2020-03-14 18:35 ` Andrew Lunn
2020-03-14 10:15 ` [PATCH net-next 3/8] net: dsa: mv88e6xxx: configure interface settings in mac_config Russell King
2020-03-14 18:38 ` Andrew Lunn
2020-03-14 10:15 ` [PATCH net-next 4/8] net: dsa: mv88e6xxx: extend phylink to Serdes PHYs Russell King
2020-03-14 18:47 ` Andrew Lunn
2020-03-14 10:15 ` [PATCH net-next 5/8] net: dsa: mv88e6xxx: fix Serdes link changes Russell King
2020-03-14 18:48 ` Andrew Lunn
2020-03-14 10:15 ` [PATCH net-next 6/8] net: dsa: mv88e6xxx: combine port_set_speed and port_set_duplex Russell King
2020-03-14 18:49 ` Andrew Lunn
2020-03-14 10:15 ` [PATCH net-next 7/8] net: dsa: mv88e6xxx: remove port_link_state functions Russell King
2020-03-14 21:29 ` Andrew Lunn [this message]
2020-03-14 10:16 ` [PATCH net-next 8/8] net: dsa: mv88e6xxx: use PHY_DETECT in mac_link_up/mac_link_down Russell King
2020-03-14 21:31 ` Andrew Lunn
2020-03-14 18:33 ` [PATCH REPOST net-next 0/8] net: dsa: improve serdes integration Andrew Lunn
2020-03-16 0:11 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200314212924.GD8622@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=rmk+kernel@armlinux.org.uk \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.