From: Benjamin Marzinski <bmarzins@redhat.com>
To: mwilck@suse.com
Cc: dm-devel@redhat.com, David Bond <dbond@suse.com>
Subject: Re: [PATCH 1/4] libmpathpersist: limit PRIN allocation length to 8192 bytes
Date: Sat, 14 Mar 2020 18:14:15 -0500 [thread overview]
Message-ID: <20200314231415.GR30153@octiron.msp.redhat.com> (raw)
In-Reply-To: <20200306230605.3473-2-mwilck@suse.com>
On Sat, Mar 07, 2020 at 12:06:02AM +0100, mwilck@suse.com wrote:
> From: Martin Wilck <mwilck@suse.com>
>
> Some targets (notably the qemu-pr-helper) don't support PERSISTENT
> RESERVE IN commands with more than 8192 bytes allocation length.
> While I have found no explicit requirement in the SCSI specs that
> the allocation lengh may not exceed 8k, an 8k limit is also enforced
> by sg_persist(8), and actually by mpathpersist itself for the
> --allocation-length option, but not for the auto-determined length.
>
> Fix that.
>
Reviewed-by: Benjamin Marzinski <bmarzins@redhat.com>
> Signed-off-by: Martin Wilck <mwilck@suse.com>
> ---
> libmpathpersist/mpath_pr_ioctl.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/libmpathpersist/mpath_pr_ioctl.c b/libmpathpersist/mpath_pr_ioctl.c
> index 74b26b0c..1a28cba7 100644
> --- a/libmpathpersist/mpath_pr_ioctl.c
> +++ b/libmpathpersist/mpath_pr_ioctl.c
> @@ -543,5 +543,7 @@ int get_prin_length(int rq_servact)
> mx_resp_len = 0;
> break;
> }
> + if (mx_resp_len > MPATH_MAX_PARAM_LEN)
> + mx_resp_len = MPATH_MAX_PARAM_LEN;
> return mx_resp_len;
> }
> --
> 2.25.1
next prev parent reply other threads:[~2020-03-14 23:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-06 23:06 [PATCH 0/4] libmpathpersist allocation size fixes mwilck
2020-03-06 23:06 ` [PATCH 1/4] libmpathpersist: limit PRIN allocation length to 8192 bytes mwilck
2020-03-14 23:14 ` Benjamin Marzinski [this message]
2020-03-06 23:06 ` [PATCH 2/4] libmpathpersist: format_transportids(): avoid PROUT overflow mwilck
2020-03-14 23:15 ` Benjamin Marzinski
2020-03-15 0:14 ` Martin Wilck
2020-03-06 23:06 ` [PATCH 3/4] libmpathpersist: mpath_format_readfullstatus(): use real buffer size mwilck
2020-03-14 23:16 ` Benjamin Marzinski
2020-03-06 23:06 ` [PATCH 4/4] libmpathpersist: ABI change: limit data-in/out size to 8192 bytes mwilck
2020-03-15 0:19 ` Benjamin Marzinski
2020-03-15 0:27 ` Martin Wilck
2020-03-15 20:45 ` Martin Wilck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200314231415.GR30153@octiron.msp.redhat.com \
--to=bmarzins@redhat.com \
--cc=dbond@suse.com \
--cc=dm-devel@redhat.com \
--cc=mwilck@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.