From: Jonathan Cameron <jic23@kernel.org>
To: YueHaibing <yuehaibing@huawei.com>
Cc: <lars@metafoo.de>, <Michael.Hennerich@analog.com>,
<stefan.popa@analog.com>, <knaack.h@gmx.de>, <pmeerw@pmeerw.net>,
<linux-iio@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] iio:ad7797: Use correct attribute_group
Date: Sun, 15 Mar 2020 09:17:38 +0000 [thread overview]
Message-ID: <20200315091738.71f9dddf@archlinux> (raw)
In-Reply-To: <20200310141654.7188-1-yuehaibing@huawei.com>
On Tue, 10 Mar 2020 22:16:54 +0800
YueHaibing <yuehaibing@huawei.com> wrote:
> It should use ad7797_attribute_group in ad7797_info,
> according to commit ("iio:ad7793: Add support for the ad7796 and ad7797").
>
> Scale is fixed for the ad7796 and not programmable, hence
> should not have the scale_available attribute.
>
> Fixes: fd1a8b912841 ("iio:ad7793: Add support for the ad7796 and ad7797")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> Reviewed-by: Lars-Peter Clausen <lars@metafoo.de>
Thanks,
I've queued this up. Won't push out just yet as I'm waiting for
Greg to pick up a pull request after which I'd like to fast forward
the fixes branch.
Thanks,
Jonathan
> ---
> v2: renew log as Lars-Peter's comment
>
> drivers/iio/adc/ad7793.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/ad7793.c b/drivers/iio/adc/ad7793.c
> index b747db9..e5691e3 100644
> --- a/drivers/iio/adc/ad7793.c
> +++ b/drivers/iio/adc/ad7793.c
> @@ -542,7 +542,7 @@ static const struct iio_info ad7797_info = {
> .read_raw = &ad7793_read_raw,
> .write_raw = &ad7793_write_raw,
> .write_raw_get_fmt = &ad7793_write_raw_get_fmt,
> - .attrs = &ad7793_attribute_group,
> + .attrs = &ad7797_attribute_group,
> .validate_trigger = ad_sd_validate_trigger,
> };
>
next prev parent reply other threads:[~2020-03-15 9:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-02 13:32 [PATCH -next] iio:ad7797: Use correct attribute_group YueHaibing
2020-03-04 6:35 ` Ardelean, Alexandru
2020-03-07 13:10 ` Jonathan Cameron
2020-03-09 1:38 ` Yuehaibing
2020-03-09 10:12 ` Lars-Peter Clausen
2020-03-10 14:16 ` [PATCH v2] " YueHaibing
2020-03-15 9:17 ` Jonathan Cameron [this message]
2020-03-09 10:10 ` [PATCH -next] " Lars-Peter Clausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200315091738.71f9dddf@archlinux \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=stefan.popa@analog.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.