Re: [PATCH] staging: speakup: main: switch multiple assignment for one assignment per line

[Samuel Thibault <samuel.thibault@ens-lyon.org>]

Hello,

Lourdes Pedrajas, le dim. 15 mars 2020 05:40:51 +0100, a ecrit:
> One assignment per line is preferred, instead of multiple assignments.
> To prevent possible undefined behavior.

Here the behavior is completely defined, but one assignment per line
makes it more readable.

> Issue found with checkpath.
> 
> Signed-off-by: Lourdes Pedrajas <lu@pplo.net>
> ---
>  drivers/staging/speakup/main.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/main.c
> index 488f2539aa9a..d363009863e3 100644
> --- a/drivers/staging/speakup/main.c
> +++ b/drivers/staging/speakup/main.c
> @@ -2117,7 +2117,8 @@ speakup_key(struct vc_data *vc, int shift_state, int keycode, u_short keysym,
>  			spk_keydown = 0;
>  			goto out;
>  		}
> -		value = spk_lastkey = pad_chars[value];
> +		spk_lastkey = pad_chars[value];
> +		value = pad_chars[value];

Please rather use

		value = pad_chars[value];
		spk_lastkey = value

To make it clear that it's the same value which is used, and to have the
spk_something assignment next to the other spk_something assignments.

>  		spk_keydown++;
>  		spk_parked &= 0xfe;
>  		goto no_map;
> -- 
> 2.17.1
>