From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/3] package/automake: also include autoconf-archive in search paths
Date: Sun, 15 Mar 2020 16:30:27 +0100 [thread overview]
Message-ID: <20200315163027.03f63f78@windsurf> (raw)
In-Reply-To: <20200210142721.3390d716@windsurf>
On Mon, 10 Feb 2020 14:27:21 +0100
Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote:
> On Sun, 9 Feb 2020 16:12:41 +0100
> "Yann E. MORIN" <yann.morin.1998@free.fr> wrote:
>
> > diff --git a/package/automake/automake.mk b/package/automake/automake.mk
> > index 89dcaa1293..238116cb94 100644
> > --- a/package/automake/automake.mk
> > +++ b/package/automake/automake.mk
> > @@ -33,5 +33,11 @@ $(eval $(host-autotools-package))
> > AUTOMAKE = $(HOST_DIR)/bin/automake
> > ACLOCAL_DIR = $(STAGING_DIR)/usr/share/aclocal
> > ACLOCAL = $(HOST_DIR)/bin/aclocal
> > -ACLOCAL_PATH = $(ACLOCAL_DIR):$(ACLOCAL_HOST_DIR)
> > +ACLOCAL_PATH = $(subst $(space),:,$(strip \
> > + $(ACLOCAL_DIR) \
> > + $(ACLOCAL_HOST_DIR) \
> > + $(if $(filter host-autoconf-archive,$($(PKG)_FINAL_ALL_DEPENDENCIES)),\
> > + $(HOST_DIR)/share/autoconf-archive \
> > + ) \
> > +))
>
> Meh :-/ Can we add something more explicit than that in the
> infrastructure? Poking around in the package dependencies like this to
> second guess which path should be added to ACLOCAL_PATH is not really
> great :-/
So I've marked PATCH 2/3 and 3/3 as Rejected. We fixed the sdbusplus
issue by re-adding the hook creating the m4 directory. I understand the
idea of having more "automatic", but this approach of looking at the
dependencies of the package felt really odd.
We can always revisit this of course.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2020-03-15 15:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-09 15:12 [Buildroot] [PATCH 0/3] package: drop fallout of aclocal innclude directory revamp (branch yem/autoconf-archive) Yann E. MORIN
2020-02-09 15:12 ` [Buildroot] [PATCH 1/3] package/libsigrok: drop remnants of autoreconf Yann E. MORIN
2020-02-09 19:09 ` Heiko Thiery
2020-02-13 22:26 ` Peter Korsgaard
2020-02-09 15:12 ` [Buildroot] [PATCH 2/3] package/automake: also include autoconf-archive in search paths Yann E. MORIN
2020-02-09 15:24 ` Yann E. MORIN
2020-02-10 13:06 ` Michael Walle
2020-02-10 13:09 ` Michael Walle
2020-02-10 13:14 ` Arnout Vandecappelle
2020-02-10 13:50 ` Michael Walle
2020-02-09 19:09 ` Heiko Thiery
2020-02-10 13:27 ` Thomas Petazzoni
2020-03-15 15:30 ` Thomas Petazzoni [this message]
2020-02-09 15:12 ` [Buildroot] [PATCH 3/3] package/sdbusplus: drop broken autoreconf include directive Yann E. MORIN
2020-02-09 19:09 ` Heiko Thiery
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200315163027.03f63f78@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.