From: "brian m. carlson" <sandals@crustytoothpaste.net>
To: "SZEDER Gábor" <szeder.dev@gmail.com>
Cc: git@vger.kernel.org, Taylor Blau <me@ttaylorr.com>
Subject: Re: [PATCH 5/8] builtin/clone: compute checkout metadata for clones
Date: Sun, 15 Mar 2020 17:44:45 +0000 [thread overview]
Message-ID: <20200315174445.GA6910@camp.crustytoothpaste.net> (raw)
In-Reply-To: <20200315103929.GH3122@szeder.dev>
[-- Attachment #1: Type: text/plain, Size: 648 bytes --]
On 2020-03-15 at 10:39:29, SZEDER Gábor wrote:
> On Tue, Mar 10, 2020 at 06:20:43PM +0000, brian m. carlson wrote:
> > diff --git a/builtin/clone.c b/builtin/clone.c
> > index 1ad26f4d8c..00e5427ef1 100644
> > --- a/builtin/clone.c
> > +++ b/builtin/clone.c
> > @@ -780,11 +780,12 @@ static int checkout(int submodule_progress)
> > if (!strcmp(head, "HEAD")) {
> > if (advice_detached_head)
> > detach_advice(oid_to_hex(&oid));
> > + free(head);
> > + head = NULL;
>
> Coccinelle suggests to use FREE_AND_NULL(head) instead.
I'll do that.
--
brian m. carlson: Houston, Texas, US
OpenPGP: https://keybase.io/bk2204
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 263 bytes --]
next prev parent reply other threads:[~2020-03-15 17:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-10 18:20 [PATCH 0/8] Additional metadata for filter processes brian m. carlson
2020-03-10 18:20 ` [PATCH 1/8] builtin/checkout: pass branch info down to checkout_worktree brian m. carlson
2020-03-10 18:20 ` [PATCH 2/8] convert: permit passing additional metadata to filter processes brian m. carlson
2020-03-11 20:38 ` Junio C Hamano
2020-03-12 0:39 ` brian m. carlson
2020-03-10 18:20 ` [PATCH 3/8] convert: provide additional metadata to filters brian m. carlson
2020-03-10 18:20 ` [PATCH 4/8] builtin/checkout: compute checkout metadata for checkouts brian m. carlson
2020-03-10 18:20 ` [PATCH 5/8] builtin/clone: compute checkout metadata for clones brian m. carlson
2020-03-15 10:39 ` SZEDER Gábor
2020-03-15 17:44 ` brian m. carlson [this message]
2020-03-15 19:30 ` Junio C Hamano
2020-03-10 18:20 ` [PATCH 6/8] builtin/rebase: compute checkout metadata for rebases brian m. carlson
2020-03-10 18:20 ` [PATCH 7/8] builtin/reset: compute checkout metadata for reset brian m. carlson
2020-03-10 18:20 ` [PATCH 8/8] t0021: test filter metadata for additional cases brian m. carlson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200315174445.GA6910@camp.crustytoothpaste.net \
--to=sandals@crustytoothpaste.net \
--cc=git@vger.kernel.org \
--cc=me@ttaylorr.com \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.