From: Stefano Brivio <sbrivio@redhat.com>
To: Enrique Vargas <jevargas@seas.upenn.edu>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
Michael Hennerich <Michael.Hennerich@analog.com>,
Stefan Popa <stefan.popa@analog.com>,
Jonathan Cameron <jic23@kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH] Staging: iio: adc: eliminate spaces at the start of lineslinux-iio@vger.kernel.org
Date: Sun, 15 Mar 2020 21:35:16 +0100 [thread overview]
Message-ID: <20200315213516.6c27408f@elisabeth> (raw)
In-Reply-To: <20200312140911.GA731@evX1>
Hi Enrique,
For some reason, an address you wanted to Cc: ended up in the subject.
A couple of comments:
- well, yes, I see you're removing spaces at the start of some lines,
but you're also replacing them by tabs, and doing it in an enum...
maybe that could be part of the commit title?
Also,
On Thu, 12 Mar 2020 08:09:11 -0600
Enrique Vargas <jevargas@seas.upenn.edu> wrote:
> Eliminate WARNING found with checkpatch.pl related to spaces
> inconsistency on identation.
^^^ indentation.
The rest looks good to me! Can you please send a new version?
--
Stefano
prev parent reply other threads:[~2020-03-15 20:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-12 14:09 [PATCH] Staging: iio: adc: eliminate spaces at the start of lineslinux-iio@vger.kernel.org Enrique Vargas
2020-03-15 20:35 ` Stefano Brivio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200315213516.6c27408f@elisabeth \
--to=sbrivio@redhat.com \
--cc=Michael.Hennerich@analog.com \
--cc=gregkh@linuxfoundation.org \
--cc=jevargas@seas.upenn.edu \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=outreachy-kernel@googlegroups.com \
--cc=pmeerw@pmeerw.net \
--cc=stefan.popa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.