From: Stefano Brivio <sbrivio@redhat.com>
To: Lourdes Pedrajas <lu@pplo.net>
Cc: outreachy-kernel@googlegroups.com, gregkh@linuxfoundation.org
Subject: Re: [Outreachy kernel] [PATCH v5] staging: rtl8192u: r8192U_wx: use netdev_warn() instead of printk()
Date: Sun, 15 Mar 2020 22:17:56 +0100 [thread overview]
Message-ID: <20200315221756.43c21285@elisabeth> (raw)
In-Reply-To: <20200313090544.6334-1-lu@pplo.net>
On Fri, 13 Mar 2020 10:05:44 +0100
Lourdes Pedrajas <lu@pplo.net> wrote:
> printk() is deprecated, use netdev_warn() instead, which is a message printing
> function specific for network devices.
> Issue found by checkpatch.
>
> Suggested-by: Julia Lawall <julia.lawall@inria.fr>
> Suggested-by: Stefano Brivio <sbrivio@redhat.com>
> Signed-off-by: Lourdes Pedrajas <lu@pplo.net>
> ---
> Changes since v4:
> - Log message correction.
>
> drivers/staging/rtl8192u/r8192U_wx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8192u/r8192U_wx.c b/drivers/staging/rtl8192u/r8192U_wx.c
> index 0118edb0b9ab..100532598781 100644
> --- a/drivers/staging/rtl8192u/r8192U_wx.c
> +++ b/drivers/staging/rtl8192u/r8192U_wx.c
> @@ -588,7 +588,7 @@ static int r8192_wx_set_enc(struct net_device *dev,
> hwkey); /* KeyContent */
>
> } else {
> - printk("wrong type in WEP, not WEP40 and WEP104\n");
> + netdev_warn(dev, "wrong type in WEP, not WEP40 and WEP104\n");
Reviewed-by: Stefano Brivio <sbrivio@redhat.com>
--
Stefano
next prev parent reply other threads:[~2020-03-15 21:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-13 9:05 [PATCH v5] staging: rtl8192u: r8192U_wx: use netdev_warn() instead of printk() Lourdes Pedrajas
2020-03-15 21:17 ` Stefano Brivio [this message]
2020-03-17 11:48 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2020-03-12 21:05 Lourdes Pedrajas
2020-03-13 7:04 ` [Outreachy kernel] " Julia Lawall
2020-03-13 9:04 ` Lourdes Pedrajas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200315221756.43c21285@elisabeth \
--to=sbrivio@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=lu@pplo.net \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.