All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] package/libcpprestsdk: zlib is optional, not mandatory
Date: Sun, 15 Mar 2020 22:47:51 +0100	[thread overview]
Message-ID: <20200315224751.41147871@windsurf> (raw)
In-Reply-To: <20200314222027.2317520-1-fontaine.fabrice@gmail.com>

On Sat, 14 Mar 2020 23:20:26 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> +ifeq ($(BR2_PACKAGE_ZLIB),y)
> +LIBCPPRESTSDK_DEPENDENCIES += zlib
> +LIBCPPRESTSDK_CONF_OPTS += -DCPPREST_EXCLUDE_COMPRESSION=OFF
> +# brotli needs compression

What makes you think brotli needs zlib ? I had a quick look at the
CMake logic and didn't find that.

Also, how did you test that? zlib is a dependency of openssl, and
openssl is a mandatory dependency of libcpprestsdk. Did you test with
libressl ?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  parent reply	other threads:[~2020-03-15 21:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-14 22:20 [Buildroot] [PATCH 1/2] package/libcpprestsdk: zlib is optional, not mandatory Fabrice Fontaine
2020-03-14 22:20 ` [Buildroot] [PATCH 2/2] package/libcpprestsdk: needs locale Fabrice Fontaine
2020-03-15 21:47   ` Thomas Petazzoni
2020-03-15 21:47 ` Thomas Petazzoni [this message]
2020-03-15 22:41   ` [Buildroot] [PATCH 1/2] package/libcpprestsdk: zlib is optional, not mandatory Fabrice Fontaine
2020-04-25 13:46 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200315224751.41147871@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.