From: Shawn Guo <shawnguo@kernel.org>
To: Marek Vasut <marex@denx.de>
Cc: Christoph Niedermaier <cniedermaier@dh-electronics.com>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] ARM: dts: imx6q-dhcom: Add DH 560-200 display unit support
Date: Mon, 16 Mar 2020 09:00:49 +0800 [thread overview]
Message-ID: <20200316010048.GH17221@dragon> (raw)
In-Reply-To: <3aaa5319-f815-5e69-ea44-632bd7a6a389@denx.de>
On Tue, Mar 10, 2020 at 10:10:36PM +0100, Marek Vasut wrote:
> On 3/10/20 10:08 AM, Christoph Niedermaier wrote:
> > Hi Marek,
>
> Hi,
>
> > From: linux-arm-kernel [mailto:linux-arm-kernel-bounces@lists.infradead.org] On Behalf Of Marek Vasut
> > Sent: Monday, March 9, 2020 9:08 PM
> >
> >> + display_bl: display-bl {
> >> + compatible = "pwm-backlight";
> >> + pwms = <&pwm1 0 50000 PWM_POLARITY_INVERTED>;
> >> + brightness-levels = <0 16 22 30 40 55 75 102 138 188 255>;
> >> + default-brightness-level = <8>;
> >> + enable-gpios = <&gpio3 27 GPIO_ACTIVE_HIGH>;
> >> + status = "okay";
> >> + };
> > ...
> >> +&pwm1 {
> >> + pinctrl-names = "default";
> >> + pinctrl-0 = <&pinctrl_pwm1>;
> >> + status = "okay";
> >> +};
> >
> > To get PWM_POLARITY_INVERTED, shouldn't we add the following line to pwm1:
> > #pwm-cells = <3>;
>
> It seems some boards do set it, some do not, although that might also be
> a bug in the DT of those other board files or I'm reading it wrong.
> Let's see what the maintainers have to say.
The binding doc says we should have it.
Shawn
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2020-03-16 1:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-09 20:08 [PATCH] ARM: dts: imx6q-dhcom: Add DH 560-200 display unit support Marek Vasut
2020-03-10 9:08 ` Christoph Niedermaier
2020-03-10 21:10 ` Marek Vasut
2020-03-16 1:00 ` Shawn Guo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200316010048.GH17221@dragon \
--to=shawnguo@kernel.org \
--cc=cniedermaier@dh-electronics.com \
--cc=festevam@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=marex@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.