All of lore.kernel.org
 help / color / mirror / Atom feed
From: Veera <vkor@vkten.in>
To: Stefano Brivio <sbrivio@redhat.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Larry Finger <Larry.Finger@lwfinger.net>,
	Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
	outreachy-kernel <outreachy-kernel@googlegroups.com>
Subject: Re: [Outreachy kernel] [PATCH v2] staging: rtl8712: Better Fix for long lines in Kconfig help
Date: Tue, 17 Mar 2020 07:27:30 +0530	[thread overview]
Message-ID: <20200317015728.GA5977@lily.local> (raw)
In-Reply-To: <20200317015008.66b7d14c@elisabeth>

On Tue, Mar 17, 2020 at 01:50:08AM +0100, Stefano Brivio wrote:
> Hi Veera,
> 
> Note that who reads the commit title won't know in which way this is
> "better" than v1, because v1 isn't tracked by git. I think the "Better"
> part should be omitted in the title. Looks good to me otherwise, just
> one minor comment:
> 

Okay.

The "better" thing is coming from "Outreachyfirstpatch - Linux Kernel
Newbies.html" page.

Should I make a new patch revision and send again?

Veera

> On Fri, 13 Mar 2020 21:46:45 +0530
> R Veera Kumar <vkor@vkten.in> wrote:
> 
> > Fixes two long line in Kconfig help.
>                  ^^^^ lines
> 
> -- 
> Stefano
> 


  reply	other threads:[~2020-03-17  1:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-13 16:16 [PATCH v2] staging: rtl8712: Better Fix for long lines in Kconfig help R Veera Kumar
2020-03-17  0:50 ` [Outreachy kernel] " Stefano Brivio
2020-03-17  1:57   ` Veera [this message]
2020-03-17  9:41     ` Stefano Brivio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200317015728.GA5977@lily.local \
    --to=vkor@vkten.in \
    --cc=Larry.Finger@lwfinger.net \
    --cc=florian.c.schilhabel@googlemail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=outreachy-kernel@googlegroups.com \
    --cc=sbrivio@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.