All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefano Brivio <sbrivio@redhat.com>
To: Deepak R Varma <mh12gx2825@gmail.com>
Cc: outreachy-kernel@googlegroups.com, gregkh@linuxfoundation.org,
	daniel.baluta@gmail.com, mchehab@kernel.org,
	sakari.ailus@linux.intel.com
Subject: Re: [Outreachy kernel] [PATCH] media: staging/intel-ipu3: Reformat pointer definition
Date: Tue, 17 Mar 2020 02:10:36 +0100	[thread overview]
Message-ID: <20200317021036.7fe16fe4@elisabeth> (raw)
In-Reply-To: <20200313183827.GA20795@deeUbuntu>

On Sat, 14 Mar 2020 00:08:30 +0530
Deepak R Varma <mh12gx2825@gmail.com> wrote:

> Reformat pointer definition to make it more readable as per the coding
> standards. Problem detected by checkpatch.

What you're actually changing here is the assignment or initialisation,
not the definition.

Can you please re-send this with adjusted description and title? The
rest looks good to me, except for the unrelated change:

> 
> Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com>
> ---
>  drivers/staging/media/ipu3/ipu3-v4l2.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/media/ipu3/ipu3-v4l2.c b/drivers/staging/media/ipu3/ipu3-v4l2.c
> index 569e27b824c8..52826fad6f42 100644
> --- a/drivers/staging/media/ipu3/ipu3-v4l2.c
> +++ b/drivers/staging/media/ipu3/ipu3-v4l2.c
> @@ -485,7 +485,6 @@ static int imgu_vb2_start_streaming(struct vb2_queue *vq, unsigned int count)
>  	if (r < 0)
>  		goto fail_return_bufs;
>  
> -

here.

-- 
Stefano



      reply	other threads:[~2020-03-17  1:11 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-13 18:38 [PATCH] media: staging/intel-ipu3: Reformat pointer definition Deepak R Varma
2020-03-17  1:10 ` Stefano Brivio [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200317021036.7fe16fe4@elisabeth \
    --to=sbrivio@redhat.com \
    --cc=daniel.baluta@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=mchehab@kernel.org \
    --cc=mh12gx2825@gmail.com \
    --cc=outreachy-kernel@googlegroups.com \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.