Re: [PATCH V3] PCI: rcar: Add the suspend/resume for pcie-rcar driver

[kbuild test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2953 bytes --]

Hi,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on pci/next]
[also build test ERROR on v5.6-rc6 next-20200312]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/marek-vasut-gmail-com/PCI-rcar-Add-the-suspend-resume-for-pcie-rcar-driver/20200317-023853
base:   https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next
config: parisc-allyesconfig (attached as .config)
compiler: hppa-linux-gcc (GCC) 9.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=9.2.0 make.cross ARCH=parisc 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/pci/controller/pcie-rcar.c: In function 'rcar_pcie_hw_enable':
>> drivers/pci/controller/pcie-rcar.c:474:35: error: passing argument 3 of 'rcar_pcie_setup_window' from incompatible pointer type [-Werror=incompatible-pointer-types]
     474 |    rcar_pcie_setup_window(i, pci, win);
         |                                   ^~~
         |                                   |
         |                                   struct resource_entry *
   drivers/pci/controller/pcie-rcar.c:336:25: note: expected 'struct resource *' but argument is of type 'struct resource_entry *'
     336 |        struct resource *res)
         |        ~~~~~~~~~~~~~~~~~^~~
   At top level:
   drivers/pci/controller/pcie-rcar.c:1252:12: warning: 'rcar_pcie_resume' defined but not used [-Wunused-function]
    1252 | static int rcar_pcie_resume(struct device *dev)
         |            ^~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors

vim +/rcar_pcie_setup_window +474 drivers/pci/controller/pcie-rcar.c

   454	
   455	static void rcar_pcie_hw_enable(struct rcar_pcie *pci)
   456	{
   457		struct resource_entry *win;
   458		LIST_HEAD(res);
   459		int i = 0;
   460	
   461		/* Try setting 5 GT/s link speed */
   462		rcar_pcie_force_speedup(pci);
   463	
   464		/* Setup PCI resources */
   465		resource_list_for_each_entry(win, &pci->resources) {
   466			struct resource *res = win->res;
   467	
   468			if (!res->flags)
   469				continue;
   470	
   471			switch (resource_type(res)) {
   472			case IORESOURCE_IO:
   473			case IORESOURCE_MEM:
 > 474				rcar_pcie_setup_window(i, pci, win);
   475				i++;
   476				break;
   477			}
   478		}
   479	}
   480	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 60441 bytes --]