From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 565C0C18E5B for ; Tue, 17 Mar 2020 10:59:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2E4B320714 for ; Tue, 17 Mar 2020 10:59:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584442796; bh=2vhibI530la2nXP38czFOi1Gon/TlBG9XWRRNIpIJCA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=rviGzG2AAJr/BQa/OyDr7DlLlqsnJU+0PvOI7igz5heUDrmEaaFZTFfR67UdAws/D r5KliWRvE5v1Uof+Kd0vXwQ/Ev5l1x2QBkcExOECkoxZnxl9mdrjjA+1SQPwUchhaP jvJINbwB6rN0nmvpNZkNvhd+ZXBzem1MWd6SJ3SY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727529AbgCQK7z (ORCPT ); Tue, 17 Mar 2020 06:59:55 -0400 Received: from mail.kernel.org ([198.145.29.99]:38418 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727501AbgCQK7r (ORCPT ); Tue, 17 Mar 2020 06:59:47 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0106B20658; Tue, 17 Mar 2020 10:59:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584442787; bh=2vhibI530la2nXP38czFOi1Gon/TlBG9XWRRNIpIJCA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bu/ZPr3CMJIQf26lsF9NAPiH3dYNbxc337arX2ijaeeAQQ/0g3TFsA2XGcK9kxgRH sp/jkI9tEyZmugeinMk9VuwnsvWBZbxC+VSD+e60YWPtcJJ4t04prfciGwder/pEoR sbw513YDPdd/o2v5IEeIlg0om/mT3tDmF1pcpy3A= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Lu Baolu , Zhenzhong Duan , Joerg Roedel Subject: [PATCH 4.19 82/89] iommu/vt-d: Fix the wrong printing in RHSA parsing Date: Tue, 17 Mar 2020 11:55:31 +0100 Message-Id: <20200317103309.528602707@linuxfoundation.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200317103259.744774526@linuxfoundation.org> References: <20200317103259.744774526@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Zhenzhong Duan commit b0bb0c22c4db623f2e7b1a471596fbf1c22c6dc5 upstream. When base address in RHSA structure doesn't match base address in each DRHD structure, the base address in last DRHD is printed out. This doesn't make sense when there are multiple DRHD units, fix it by printing the buggy RHSA's base address. Signed-off-by: Lu Baolu Signed-off-by: Zhenzhong Duan Fixes: fd0c8894893cb ("intel-iommu: Set a more specific taint flag for invalid BIOS DMAR tables") Signed-off-by: Joerg Roedel Signed-off-by: Greg Kroah-Hartman --- drivers/iommu/dmar.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/iommu/dmar.c +++ b/drivers/iommu/dmar.c @@ -486,7 +486,7 @@ static int dmar_parse_one_rhsa(struct ac pr_warn(FW_BUG "Your BIOS is broken; RHSA refers to non-existent DMAR unit at %llx\n" "BIOS vendor: %s; Ver: %s; Product Version: %s\n", - drhd->reg_base_addr, + rhsa->base_address, dmi_get_system_info(DMI_BIOS_VENDOR), dmi_get_system_info(DMI_BIOS_VERSION), dmi_get_system_info(DMI_PRODUCT_VERSION));