From: Greg KH <gregkh@linuxfoundation.org>
To: Payal Kshirsagar <payalskshirsagar1234@gmail.com>
Cc: Julia Lawall <julia.lawall@inria.fr>, outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH 0/3] staging: rtl8723bs: remove unneeded local variables
Date: Tue, 17 Mar 2020 12:38:49 +0100 [thread overview]
Message-ID: <20200317113849.GA1222404@kroah.com> (raw)
In-Reply-To: <f46d12c4e5ae5dbe5ff6d1faffcb14d02799da5f.camel@gmail.com>
On Sun, Mar 15, 2020 at 03:51:24PM +0530, Payal Kshirsagar wrote:
> On Sun, 2020-03-15 at 09:40 +0100, Julia Lawall wrote:
> >
> > On Sun, 15 Mar 2020, Payal Kshirsagar wrote:
> >
> > > On Fri, 2020-03-13 at 20:26 +0100, Julia Lawall wrote:
> > > >
> > > > On Fri, 13 Mar 2020, Payal Kshirsagar wrote:
> > > >
> > > > > Remove unneeded variables and their declarations from the files
> > > > > of
> > > > > staging/rtl8723bs directory.
> > > > >
> > > > > Payal Kshirsagar (3):
> > > > > staging: rtl8723bs: hal: hal_com.c: remove unneeded variable
> > > > > staging: rtl8723bs: core: rtw_io.c: remove unneeded variables
> > > > > staging: rtl8723bs: core: rtw_pwrctrl.c: remove unneeded
> > > > > variable
> > > >
> > > > The subject lines should be created according to what others have
> > > > done for
> > > > these files. In any case, there should not be .c
> > > >
> > >
> > > Since I had done same change in all the files in only a single
> > > directory, I needed to add their names to make the seperate patches
> > > for
> > > each file.
> >
> > Someone suggested that still there should not be the .c part.
>
> Okay, I will make sure from next time:)
Please fix this and make sure _this_ time :)
next prev parent reply other threads:[~2020-03-17 11:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-13 15:36 [PATCH 0/3] staging: rtl8723bs: remove unneeded local variables Payal Kshirsagar
2020-03-13 15:36 ` [PATCH 1/3] staging: rtl8723bs: hal: hal_com.c: remove unneeded variable Payal Kshirsagar
2020-03-13 15:36 ` [PATCH 2/3] staging: rtl8723bs: core: rtw_io.c: remove unneeded variables Payal Kshirsagar
2020-03-13 15:36 ` [PATCH 3/3] staging: rtl8723bs: core: rtw_pwrctrl.c: remove unneeded variable Payal Kshirsagar
2020-03-13 19:26 ` [Outreachy kernel] [PATCH 0/3] staging: rtl8723bs: remove unneeded local variables Julia Lawall
2020-03-15 5:59 ` Payal Kshirsagar
2020-03-15 8:40 ` Julia Lawall
2020-03-15 10:21 ` Payal Kshirsagar
2020-03-17 11:38 ` Greg KH [this message]
2020-03-21 7:35 ` Payal Kshirsagar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200317113849.GA1222404@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=julia.lawall@inria.fr \
--cc=outreachy-kernel@googlegroups.com \
--cc=payalskshirsagar1234@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.