From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D56FC10F29 for ; Tue, 17 Mar 2020 12:56:40 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2E76B205ED for ; Tue, 17 Mar 2020 12:56:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Z9abuDqK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2E76B205ED Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:60776 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jEBlv-0001GM-AL for qemu-devel@archiver.kernel.org; Tue, 17 Mar 2020 08:56:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57619) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jEBl9-00008n-9R for qemu-devel@nongnu.org; Tue, 17 Mar 2020 08:55:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jEBl7-0002mG-LS for qemu-devel@nongnu.org; Tue, 17 Mar 2020 08:55:50 -0400 Received: from us-smtp-delivery-74.mimecast.com ([216.205.24.74]:43950) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jEBl7-0002el-Gv for qemu-devel@nongnu.org; Tue, 17 Mar 2020 08:55:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1584449748; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=H0UuKxEDh3fgRaz+8yGg+NodPJ4WkjVrVVRmapJO8sA=; b=Z9abuDqKe2cbrl3EEERkjnbQslu4JW7k0QZ9afrpum98PotmPXHxZl+yymeW6oDRq3dQf7 MQYtKMJR3hMDk1bR223xmWsRab2igIBjg2XfHv5GkNyN0qZGIk89w3SlmwoG/mqQEVJb/k sed5YVfRIv2VR/rnkKf9pYVqpHDrKLc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-87-ct5E31ZfOKqaLoTXelUwMg-1; Tue, 17 Mar 2020 08:55:47 -0400 X-MC-Unique: ct5E31ZfOKqaLoTXelUwMg-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 53D82801E5C for ; Tue, 17 Mar 2020 12:55:46 +0000 (UTC) Received: from work-vm (ovpn-114-234.ams2.redhat.com [10.36.114.234]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A425919C58; Tue, 17 Mar 2020 12:55:42 +0000 (UTC) Date: Tue, 17 Mar 2020 12:55:40 +0000 From: "Dr. David Alan Gilbert" To: Igor Mammedov Subject: Re: [PATCH] vl.c/memdev: Error on bad memory backend Message-ID: <20200317125540.GB3369@work-vm> References: <20200317120759.49367-1-dgilbert@redhat.com> <20200317133418.7e084477@redhat.com> MIME-Version: 1.0 In-Reply-To: <20200317133418.7e084477@redhat.com> User-Agent: Mutt/1.13.3 (2020-01-12) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 216.205.24.74 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, =?iso-8859-1?Q?Marc-Andr=E9?= Lureau Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" * Igor Mammedov (imammedo@redhat.com) wrote: > On Tue, 17 Mar 2020 12:07:59 +0000 > "Dr. David Alan Gilbert (git)" wrote: >=20 > > From: "Dr. David Alan Gilbert" > >=20 > > If memory-backend is a non-existent object, qemu crashes. > > Check that the backend actually resolves. > >=20 > > e.g. ./qemu-system-x86_64 -machine pc,accel=3Dkvm,memory-backend=3Dfo= o >=20 > there is a patch to fix it already > [PATCH] softmmu: fix crash with invalid -M memory-backend=3D > by Marc-Andr=E9=20 >=20 > but looks like it fell through cracks ... Oops, didn't see that. (I tripped over this because I hadn't originally realised that it was an object ID rather than object type with options) Dave > >=20 > > Signed-off-by: Dr. David Alan Gilbert > > --- > > softmmu/vl.c | 5 +++++ > > 1 file changed, 5 insertions(+) > >=20 > > diff --git a/softmmu/vl.c b/softmmu/vl.c > > index ff2685dff8..76507e99c4 100644 > > --- a/softmmu/vl.c > > +++ b/softmmu/vl.c > > @@ -4288,6 +4288,11 @@ void qemu_init(int argc, char **argv, char **env= p) > > =20 > > backend =3D object_resolve_path_type(current_machine->ram_memd= ev_id, > > TYPE_MEMORY_BACKEND, NULL); > > + if (!backend) { > > + error_report("Unknown memory backend object id '%s'", > > + current_machine->ram_memdev_id); > > + exit(EXIT_FAILURE); > > + } > > backend_size =3D object_property_get_uint(backend, "size", &e= rror_abort); > > if (have_custom_ram_size && backend_size !=3D ram_size) { > > error_report("Size specified by -m option must match s= ize of " >=20 -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK