Re: [Outreachy kernel] [PATCH] staging: wilc1000: rearrange line exceeding 80 characters

[Stefano Brivio <sbrivio@redhat.com>]

On Mon, 16 Mar 2020 18:10:09 +0300
Gokce Kuler <gokcekuler@gmail.com> wrote:

> Moved to the bottom line after && operator for it exceeds 80 character
> 
> Signed-off-by: Gokce Kuler <gokcekuler@gmail.com>
> ---
>  drivers/staging/wilc1000/netdev.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/wilc1000/netdev.c b/drivers/staging/wilc1000/netdev.c
> index a61c1a7..f94a17b 100644
> --- a/drivers/staging/wilc1000/netdev.c
> +++ b/drivers/staging/wilc1000/netdev.c
> @@ -794,8 +794,10 @@ void wilc_wfi_mgmt_rx(struct wilc *wilc, u8 *buff, u32 size)
>  		u16 type = le16_to_cpup((__le16 *)buff);
>  
>  		if (vif->priv.p2p_listen_state &&
> -		    ((type == vif->frame_reg[0].type && vif->frame_reg[0].reg) ||
> -		     (type == vif->frame_reg[1].type && vif->frame_reg[1].reg)))
> +		    ((type == vif->frame_reg[0].type &&
> +		      vif->frame_reg[0].reg) ||
> +		     (type == vif->frame_reg[1].type &&
> +		      vif->frame_reg[1].reg)))
>  			wilc_wfi_p2p_rx(vif, buff, size);

Strictly speaking, your change is correct and this way the code
complies to the coding style.

Still, I tried to read the "fixed" version first, and it took me a
while to "vertically" track all those parentheses. Can you find a
better way to fix this?

-- 
Stefano