From: Stefano Brivio <sbrivio@redhat.com>
To: "John B. Wyatt IV" <jbwyatt4@gmail.com>
Cc: outreachy-kernel@googlegroups.com,
Julia Lawall <julia.lawall@inria.fr>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [Outreachy kernel] [PATCH v3] staging: wlan-ng: Fix line going over 80 characters
Date: Tue, 17 Mar 2020 14:02:36 +0100 [thread overview]
Message-ID: <20200317140236.0b3020bb@elisabeth> (raw)
In-Reply-To: <20200316221544.1251350-1-jbwyatt4@gmail.com>
On Mon, 16 Mar 2020 15:15:44 -0700
"John B. Wyatt IV" <jbwyatt4@gmail.com> wrote:
> Add a newline before the second argument for style, readability, and
> consistency.
>
> Please note: checkpatch reports the third argument as being over 80
> characters, but not the second argument.
>
> Signed-off-by: John B. Wyatt IV <jbwyatt4@gmail.com>
> ---
> v3: Fixed comment misspelling as suggested by Julia Lawall <julia.lawall@inria.fr>
> Also fixed missing colon ':'
>
> v2: Fixed comment to be in the imperative as suggested by Julia Lawall <julia.lawall@inria.fr>
Reviewed-by: Stefano Brivio <sbrivio@redhat.com>
...but, please, don't forget about the unnecessary
HFA384x_RXSTATUS_MACPORT_GET() duplication here.
--
Stefano
prev parent reply other threads:[~2020-03-17 13:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-16 22:15 [PATCH v3] staging: wlan-ng: Fix line going over 80 characters John B. Wyatt IV
2020-03-17 13:02 ` Stefano Brivio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200317140236.0b3020bb@elisabeth \
--to=sbrivio@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=jbwyatt4@gmail.com \
--cc=julia.lawall@inria.fr \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.