From: Andrew Lunn <andrew@lunn.ch>
To: Russell King - ARM Linux admin <linux@armlinux.org.uk>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next 1/3] net: mdiobus: add APIs for modifying a MDIO device register
Date: Tue, 17 Mar 2020 15:09:00 +0100 [thread overview]
Message-ID: <20200317140900.GS24270@lunn.ch> (raw)
In-Reply-To: <20200316091207.GM25745@shell.armlinux.org.uk>
> > Hi Russell
> >
> > There seems to be growing push back on using BUG_ON and its
> > variants. If should only be used if the system is so badly messed up,
> > going further would only cause more damage. What really happens here
> > if it is called in interrupt context? The mutex lock probably won't
> > work, and we might corrupt the state of the PCS. That is not the end
> > of the world. So i would suggest a WARN_ON here.
>
> Do we even need these checks? (phylib has them scattered throughout
> on the bus accessors.) Aren't the might_sleep() checks that are
> already in the locking functions already sufficient?
Hi Russell
I agree, the might_sleep() should be sufficient.
Andrew
next prev parent reply other threads:[~2020-03-17 14:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-14 10:31 [PATCH REPOST3 net-next 0/3] net: add phylink support for PCS Russell King - ARM Linux admin
2020-03-14 10:31 ` [PATCH net-next 1/3] net: mdiobus: add APIs for modifying a MDIO device register Russell King
2020-03-14 21:57 ` Andrew Lunn
2020-03-16 9:12 ` Russell King - ARM Linux admin
2020-03-17 14:09 ` Andrew Lunn [this message]
2020-03-14 10:31 ` [PATCH net-next 2/3] net: phylink: pcs: add 802.3 clause 22 helpers Russell King
2020-03-14 10:31 ` [PATCH net-next 3/3] net: phylink: pcs: add 802.3 clause 45 helpers Russell King
2020-03-14 21:48 ` Andrew Lunn
2020-03-14 22:00 ` [PATCH REPOST3 net-next 0/3] net: add phylink support for PCS Andrew Lunn
2020-03-14 22:44 ` Russell King - ARM Linux admin
2020-03-17 14:18 ` Andrew Lunn
2020-03-17 15:26 ` Russell King - ARM Linux admin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200317140900.GS24270@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.