From: Christoph Hellwig <hch@infradead.org>
To: Brian Foster <bfoster@redhat.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/2] xfs: factor out quotaoff intent AIL removal and memory free
Date: Tue, 17 Mar 2020 11:36:56 -0700 [thread overview]
Message-ID: <20200317183656.GC23580@infradead.org> (raw)
In-Reply-To: <20200316170032.19552-2-bfoster@redhat.com>
On Mon, Mar 16, 2020 at 01:00:31PM -0400, Brian Foster wrote:
> AIL removal of the quotaoff start intent and free of both intents is
> hardcoded to the ->iop_committed() handler of the end intent. Factor
> out the start intent handling code so it can be used in a future
> patch to properly handle quotaoff errors. Use xfs_trans_ail_remove()
> instead of the _delete() variant to acquire the AIL lock and also
> handle cases where an intent might not reside in the AIL at the
> time of a failure.
xfs_trans_ail_delete alsmost seems nicer here rather than duplicating
the most be in ail except for abort/shutdown. But either way it looks
correct, so if you prefer it this way:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2020-03-17 18:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-16 17:00 [PATCH 0/2] xfs: quotaoff shutdown fixes Brian Foster
2020-03-16 17:00 ` [PATCH 1/2] xfs: factor out quotaoff intent AIL removal and memory free Brian Foster
2020-03-16 21:27 ` Darrick J. Wong
2020-03-17 18:36 ` Christoph Hellwig [this message]
2020-03-16 17:00 ` [PATCH 2/2] xfs: fix unmount hang and memory leak on shutdown during quotaoff Brian Foster
2020-03-16 21:32 ` Darrick J. Wong
2020-03-17 11:40 ` Brian Foster
2020-03-17 14:46 ` Darrick J. Wong
2020-03-17 14:56 ` Brian Foster
2020-03-17 18:43 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200317183656.GC23580@infradead.org \
--to=hch@infradead.org \
--cc=bfoster@redhat.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.