Re: [staging:staging-testing 222/222] drivers/ide/ide-gd.c:362:10: sparse: warning: Initializer entry defined twice

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

[-- Attachment #1: Type: text/plain, Size: 3762 bytes --]

On Wed, Mar 18, 2020 at 02:12:43PM +0800, Philip Li wrote:
> On Wed, Mar 18, 2020 at 07:08:31AM +0100, Greg Kroah-Hartman wrote:
> > On Wed, Mar 18, 2020 at 07:24:29AM +0800, kbuild test robot wrote:
> > > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-testing
> > > head:   ba839b32d6f76a68919ed838e9375c47ca05a91a
> > > commit: ba839b32d6f76a68919ed838e9375c47ca05a91a [222/222] staging: media: hantro: remove parentheses
> > > reproduce:
> > >         # apt-get install sparse
> > >         # sparse version: 
> > >         git checkout ba839b32d6f76a68919ed838e9375c47ca05a91a
> > >         make ARCH=x86_64 allmodconfig
> > >         make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
> > > 
> > > If you fix the issue, kindly add following tag
> > > Reported-by: kbuild test robot <lkp@intel.com>
> > > 
> > > All warnings (new ones prefixed by >>):
> > > 
> > > >> drivers/ide/ide-gd.c:362:10: sparse: warning: Initializer entry defined twice
> > >    drivers/ide/ide-gd.c:364:10: sparse:   also defined here
> > > --
> > > >> drivers/scsi/sr.c:689:10: sparse: warning: Initializer entry defined twice
> > >    drivers/scsi/sr.c:691:10: sparse:   also defined here
> > > --
> > > >> drivers/block/paride/pcd.c:277:10: sparse: warning: Initializer entry defined twice
> > >    drivers/block/paride/pcd.c:279:10: sparse:   also defined here
> > > --
> > > >> sound/soc/codecs/rt1015.c:844:24: sparse: warning: symbol 'rt1015_aif_dai_ops' was not declared. Should it be static?
> > > >> sound/soc/codecs/rt1015.c:849:27: sparse: warning: symbol 'rt1015_dai' was not declared. Should it be static?
> > > --
> > > >> net/netfilter/nft_set_pipapo.c:739:6: sparse: warning: symbol 'nft_pipapo_get' was not declared. Should it be static?
> > > 
> > > vim +362 drivers/ide/ide-gd.c
> > > 
> > > c103d6ee69f93e Arnd Bergmann             2019-03-15  357  
> > > 83d5cde47dedf0 Alexey Dobriyan           2009-09-21  358  static const struct block_device_operations ide_gd_ops = {
> > > 5fef0e5c028394 Bartlomiej Zolnierkiewicz 2008-10-17  359  	.owner			= THIS_MODULE,
> > > 6e9624b8caec29 Arnd Bergmann             2010-08-07  360  	.open			= ide_gd_unlocked_open,
> > > b2f21e057dfbaa Al Viro                   2008-10-16  361  	.release		= ide_gd_release,
> > > 8a6cfeb6deca3a Arnd Bergmann             2010-07-08 @362  	.ioctl			= ide_gd_ioctl,
> > > c103d6ee69f93e Arnd Bergmann             2019-03-15  363  #ifdef CONFIG_COMPAT
> > > c103d6ee69f93e Arnd Bergmann             2019-03-15  364  	.ioctl			= ide_gd_compat_ioctl,
> > > c103d6ee69f93e Arnd Bergmann             2019-03-15  365  #endif
> > > 5fef0e5c028394 Bartlomiej Zolnierkiewicz 2008-10-17  366  	.getgeo			= ide_gd_getgeo,
> > > 5b03a1b140e13a Tejun Heo                 2011-03-09  367  	.check_events		= ide_gd_check_events,
> > > c3e33e043f5e9c Tejun Heo                 2010-05-15  368  	.unlock_native_capacity	= ide_gd_unlock_native_capacity,
> > > 5fef0e5c028394 Bartlomiej Zolnierkiewicz 2008-10-17  369  	.revalidate_disk	= ide_gd_revalidate_disk
> > > 5fef0e5c028394 Bartlomiej Zolnierkiewicz 2008-10-17  370  };
> > > 5fef0e5c028394 Bartlomiej Zolnierkiewicz 2008-10-17  371  
> > > 
> > > :::::: The code at line 362 was first introduced by commit
> > > :::::: 8a6cfeb6deca3a8fefd639d898b0d163c0b5d368 block: push down BKL into .locked_ioctl
> > 
> > Why is 0-day starting to spit out sparse warnings for things that have
> > nothing to do with the specific patch, or tree?
> thanks for the input, Greg, we will check this to avoid
> false positive.

This was not the only false-positive report I got this morning, so
something went wrong on your end that started spitting out new ones :(