From: Florian Westphal <fw@strlen.de>
To: Daniel Borkmann <daniel@iogearbox.net>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
Pablo Neira Ayuso <pablo@netfilter.org>,
Alexei Starovoitov <ast@kernel.org>
Subject: Re: [PATCH net-next] netfilter: revert introduction of egress hook
Date: Wed, 18 Mar 2020 11:02:27 +0100 [thread overview]
Message-ID: <20200318100227.GE979@breakpoint.cc> (raw)
In-Reply-To: <bbdee6355234e730ef686f9321bd072bcf4bb232.1584523237.git.daniel@iogearbox.net>
Daniel Borkmann <daniel@iogearbox.net> wrote:
> This reverts the following commits:
>
> 8537f78647c0 ("netfilter: Introduce egress hook")
> 5418d3881e1f ("netfilter: Generalize ingress hook")
> b030f194aed2 ("netfilter: Rename ingress hook include file")
>
> From the discussion in [0], the author's main motivation to add a hook
> in fast path is for an out of tree kernel module, which is a red flag
> to begin with.
The author did post patches for nftables, i.e. you can hook up rulesets to
this new hook point.
> is on future extensions w/o concrete code in the tree yet. Revert as
> suggested [1] given the weak justification to add more hooks to critical
> fast-path.
Do you have an alternative suggestion on how to expose this?
next prev parent reply other threads:[~2020-03-18 10:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-18 9:33 [PATCH net-next] netfilter: revert introduction of egress hook Daniel Borkmann
2020-03-18 9:36 ` Pablo Neira Ayuso
2020-03-18 9:41 ` Daniel Borkmann
2020-03-18 9:51 ` Pablo Neira Ayuso
2020-03-18 10:02 ` Florian Westphal [this message]
2020-03-18 10:50 ` Daniel Borkmann
2020-03-18 12:33 ` Florian Westphal
2020-03-18 14:22 ` Daniel Borkmann
2020-03-19 1:45 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200318100227.GE979@breakpoint.cc \
--to=fw@strlen.de \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.