All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Lourdes Pedrajas <lu@pplo.net>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [PATCH v6] staging: rtl8192u: r8192U_wx: use netdev_warn() instead of printk()
Date: Wed, 18 Mar 2020 11:14:39 +0100	[thread overview]
Message-ID: <20200318101439.GA2082120@kroah.com> (raw)
In-Reply-To: <20200317165917.6260-1-lu@pplo.net>

On Tue, Mar 17, 2020 at 05:59:17PM +0100, Lourdes Pedrajas wrote:
> printk() is deprecated, use netdev_warn() instead, which is a message printing
> function specific for network devices.
> Issue found by checkpatch.
> 
> Suggested-by: Julia Lawall <julia.lawall@inria.fr>
> Suggested-by: Stefano Brivio <sbrivio@redhat.com>
> Signed-off-by: Lourdes Pedrajas <lu@pplo.net>
> ---
> Changes since v5:
> - Subject correction.

Thanks for sticking with this.

One further note, you should list _all_ the changes that have happened
over the series, v1-v6, in this list.  That makes it more obvious what
has happened over time.

I've queued this patch up now, no need to do it this time.

thanks,

greg k-h


  reply	other threads:[~2020-03-18 10:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-17 16:59 [PATCH v6] staging: rtl8192u: r8192U_wx: use netdev_warn() instead of printk() Lourdes Pedrajas
2020-03-18 10:14 ` Greg KH [this message]
2020-03-18 17:37   ` Lourdes Pedrajas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200318101439.GA2082120@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=lu@pplo.net \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.