From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2] syscalls/add_key05: add maxbytes/maxkeys test under unprivileged user
Date: Wed, 18 Mar 2020 14:16:14 +0100 [thread overview]
Message-ID: <20200318131614.GA12354@dell5510> (raw)
In-Reply-To: <aae4670a-74eb-36e7-6115-b41eff951405@cn.fujitsu.com>
Hi Xu,
> > Hm, I get this failure, I guess both are because missing your fix
> > 2e356101e72ab1361821b3af024d64877d9a798d, right?
> Yes, if your kernel is only with commit ("KEYS: allow reaching the keys
> quotas exact"), add_key(test_max) will fail because we don't remove this
> limit when initializing the key.
Great, thanks for a confirmation, that was my main concern.
> > add_key05.c:106: PASS: add_key(test_inv) failed as expected: EDQUOT (122)
> > add_key05.c:125: FAIL: add_key(test_max) failed unexpectedly: EDQUOT (122)
> > no crontab for ltp_add_key05
> > userdel: ltp_add_key05 home directory (/home/ltp_add_key05) not found
> > The rest looks ok to me.
> Thanks for your reivew. I will send v3 (also add save_store for keys/btyes )
OK, I'll wait for v3 (but I could also merge just this one and fix that tiny
formatting issues, up to you).
Kind regards,
Petr
next prev parent reply other threads:[~2020-03-18 13:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-07 13:14 [LTP] [PATCH] syscalls/add_key05: add maxbytes/maxkeys test under unprivileged user Yang Xu
2020-02-24 15:31 ` Cyril Hrubis
2020-02-26 10:19 ` Yang Xu
2020-02-28 7:00 ` Yang Xu
2020-02-28 8:47 ` [LTP] [PATCH v2] " Yang Xu
2020-03-17 12:32 ` Petr Vorel
2020-03-18 9:55 ` Yang Xu
2020-03-18 13:16 ` Petr Vorel [this message]
2020-03-18 13:17 ` Petr Vorel
2020-03-18 10:32 ` [LTP] [PATCH v3] " Yang Xu
2020-03-19 11:23 ` Petr Vorel
2020-03-20 5:15 ` Yang Xu
2020-03-20 11:50 ` Petr Vorel
2020-03-20 12:36 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200318131614.GA12354@dell5510 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.