From: Sean Christopherson <sean.j.christopherson@intel.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Vitaly Kuznetsov <vkuznets@redhat.com>,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH] KVM: nVMX: remove side effects from nested_vmx_exit_reflected
Date: Wed, 18 Mar 2020 08:12:08 -0700 [thread overview]
Message-ID: <20200318151207.GA24357@linux.intel.com> (raw)
In-Reply-To: <803177a8-c5ef-ac5e-087b-52b09398d78c@redhat.com>
On Wed, Mar 18, 2020 at 11:59:13AM +0100, Paolo Bonzini wrote:
> On 18/03/20 11:52, Vitaly Kuznetsov wrote:
> > The only functional difference seems to be that we're now doing
> > nested_mark_vmcs12_pages_dirty() in vmx->fail case too and this seems
> > superfluous: we failed to enter L2 so 'special' pages should remain
> > intact (right?) but this should be an uncommon case.
> >
> > Reviewed-by: Vitaly Kuznetsov <vkuznets@redhat.com>
>
> I'm not entirely sure if the PID could be written before the processor
> decrees a vmfail. It doesn't really hurt anyway as you say though.
I would expect that writing special pages on VM-Fail would be classified
as a CPU bug.
next prev parent reply other threads:[~2020-03-18 15:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-17 18:00 [PATCH] KVM: nVMX: remove side effects from nested_vmx_exit_reflected Paolo Bonzini
2020-03-18 10:52 ` Vitaly Kuznetsov
2020-03-18 10:59 ` Paolo Bonzini
2020-03-18 15:12 ` Sean Christopherson [this message]
2020-03-19 20:11 ` Krish Sadhukhan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200318151207.GA24357@linux.intel.com \
--to=sean.j.christopherson@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.