From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnaldo Carvalho de Melo Subject: Re: [PATCH v5 2/3] perf vendor events amd: add Zen2 events Date: Wed, 18 Mar 2020 12:52:45 -0300 Message-ID: <20200318155245.GJ11531@kernel.org> References: <20200316225238.150154-1-vijaythakkar@me.com> <20200316225238.150154-3-vijaythakkar@me.com> <20200318142057.GD11531@kernel.org> <20200318152112.GA231037@shwetrath.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20200318152112.GA231037@shwetrath.localdomain> Sender: linux-kernel-owner@vger.kernel.org To: Vijay Thakkar Cc: Arnaldo Carvalho de Melo , Peter Zijlstra , Ingo Molnar , Kim Phillips , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Martin =?utf-8?B?TGnFoWth?= , Jon Grimm , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org List-Id: linux-perf-users.vger.kernel.org Em Wed, Mar 18, 2020 at 11:21:12AM -0400, Vijay Thakkar escreveu: > > floating point: > > fpu_pipe_assignment.total > > [Total number of fp uOps] > > > > > > Metric Groups: > > > > I just realized that I did not add back the counters for per pipe total > assignment as I said in the commit message. Patch 3/3 adds the total > uOp assignments per pipe for Zen1 based processors. Although the PPR for > Matisse does not list these counters, I can still sample them on my > Ryzen 3900X system and they seem to report correct numbers. For example, > here is the result of running: > > $> perf stat -e r100,r200,r400,r800,rf00 ls > > $> Performance counter stats for 'ls': > > 5,047 r100:u > 5,236 r200:u > 31,300 r400:u > 2,040 r800:u > 43,623 fpu_pipe_assignment.total:u > > Note that the per pipe total counters add up the overall total, which > makes me think I should submit a v6 of this patch adding the per pipe > totals for zen2 as well, especially since it is mentioned in the commit > message. Ok, so I'll remove these patches, please redo that sequence I did in the commit log, ok? - Arnaldo