All of lore.kernel.org
 help / color / mirror / Atom feed
From: Segher Boessenkool <segher@kernel.crashing.org>
To: Christophe Leroy <christophe.leroy@c-s.fr>
Cc: Ravi Bangoria <ravi.bangoria@linux.ibm.com>,
	mikey@neuling.org, apopple@linux.ibm.com, peterz@infradead.org,
	fweisbec@gmail.com, oleg@redhat.com, npiggin@gmail.com,
	linux-kernel@vger.kernel.org, paulus@samba.org, jolsa@kernel.org,
	naveen.n.rao@linux.vnet.ibm.com, linuxppc-dev@lists.ozlabs.org,
	mingo@kernel.org
Subject: Re: [PATCH 02/15] powerpc/watchpoint: Add SPRN macros for second DAWR
Date: Wed, 18 Mar 2020 13:30:24 -0500	[thread overview]
Message-ID: <20200318183024.GJ22482@gate.crashing.org> (raw)
In-Reply-To: <0a45786d-f44b-8717-3aed-dfcfcb1856bb@c-s.fr>

On Tue, Mar 17, 2020 at 11:16:34AM +0100, Christophe Leroy wrote:
> 
> 
> Le 09/03/2020 à 09:57, Ravi Bangoria a écrit :
> >Future Power architecture is introducing second DAWR. Add SPRN_ macros
> >for the same.
> 
> I'm not sure this is called 'macros'. For me a macro is something more 
> complex.

It is called "macros" in the C standard, and in common usage as well.
"Object-like macros", as opposed to "function-like macros": there are
no arguments.

> For me those are 'constants'.

That would be more like "static const" in C since 1990 ;-)


Segher

WARNING: multiple messages have this Message-ID (diff)
From: Segher Boessenkool <segher@kernel.crashing.org>
To: Christophe Leroy <christophe.leroy@c-s.fr>
Cc: Ravi Bangoria <ravi.bangoria@linux.ibm.com>,
	mpe@ellerman.id.au, mikey@neuling.org, apopple@linux.ibm.com,
	peterz@infradead.org, fweisbec@gmail.com, oleg@redhat.com,
	npiggin@gmail.com, linux-kernel@vger.kernel.org,
	paulus@samba.org, jolsa@kernel.org,
	naveen.n.rao@linux.vnet.ibm.com, linuxppc-dev@lists.ozlabs.org,
	mingo@kernel.org
Subject: Re: [PATCH 02/15] powerpc/watchpoint: Add SPRN macros for second DAWR
Date: Wed, 18 Mar 2020 13:30:24 -0500	[thread overview]
Message-ID: <20200318183024.GJ22482@gate.crashing.org> (raw)
In-Reply-To: <0a45786d-f44b-8717-3aed-dfcfcb1856bb@c-s.fr>

On Tue, Mar 17, 2020 at 11:16:34AM +0100, Christophe Leroy wrote:
> 
> 
> Le 09/03/2020 à 09:57, Ravi Bangoria a écrit :
> >Future Power architecture is introducing second DAWR. Add SPRN_ macros
> >for the same.
> 
> I'm not sure this is called 'macros'. For me a macro is something more 
> complex.

It is called "macros" in the C standard, and in common usage as well.
"Object-like macros", as opposed to "function-like macros": there are
no arguments.

> For me those are 'constants'.

That would be more like "static const" in C since 1990 ;-)


Segher

  reply	other threads:[~2020-03-18 18:32 UTC|newest]

Thread overview: 108+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-09  8:57 [PATCH 00/15] powerpc/watchpoint: Preparation for more than one watchpoint Ravi Bangoria
2020-03-09  8:57 ` Ravi Bangoria
2020-03-09  8:57 ` [PATCH 01/15] powerpc/watchpoint: Rename current DAWR macros Ravi Bangoria
2020-03-09  8:57   ` Ravi Bangoria
2020-03-17 10:14   ` Christophe Leroy
2020-03-17 10:14     ` Christophe Leroy
2020-03-18 12:40     ` Ravi Bangoria
2020-03-18 12:40       ` Ravi Bangoria
2020-03-09  8:57 ` [PATCH 02/15] powerpc/watchpoint: Add SPRN macros for second DAWR Ravi Bangoria
2020-03-09  8:57   ` Ravi Bangoria
2020-03-17 10:16   ` Christophe Leroy
2020-03-17 10:16     ` Christophe Leroy
2020-03-18 18:30     ` Segher Boessenkool [this message]
2020-03-18 18:30       ` Segher Boessenkool
2020-03-09  8:57 ` [PATCH 03/15] powerpc/watchpoint: Introduce function to get nr watchpoints dynamically Ravi Bangoria
2020-03-09  8:57   ` Ravi Bangoria
2020-03-17 10:21   ` Christophe Leroy
2020-03-17 10:21     ` Christophe Leroy
2020-03-18  5:50     ` Ravi Bangoria
2020-03-18  5:50       ` Ravi Bangoria
2020-03-09  8:57 ` [PATCH 04/15] powerpc/watchpoint/ptrace: Return actual num of available watchpoints Ravi Bangoria
2020-03-09  8:57   ` Ravi Bangoria
2020-03-09  8:57 ` [PATCH 05/15] powerpc/watchpoint: Provide DAWR number to set_dawr Ravi Bangoria
2020-03-09  8:57   ` Ravi Bangoria
2020-03-17 10:28   ` Christophe Leroy
2020-03-17 10:28     ` Christophe Leroy
2020-03-18  6:18     ` Ravi Bangoria
2020-03-18  6:18       ` Ravi Bangoria
2020-03-09  8:57 ` [PATCH 06/15] powerpc/watchpoint: Provide DAWR number to __set_breakpoint Ravi Bangoria
2020-03-09  8:57   ` Ravi Bangoria
2020-03-09  8:57 ` [PATCH 07/15] powerpc/watchpoint: Get watchpoint count dynamically while disabling them Ravi Bangoria
2020-03-09  8:57   ` Ravi Bangoria
2020-03-17 10:32   ` Christophe Leroy
2020-03-17 10:32     ` Christophe Leroy
2020-03-18  6:57     ` Ravi Bangoria
2020-03-18  6:57       ` Ravi Bangoria
2020-03-26  3:32       ` Ravi Bangoria
2020-03-26  3:32         ` Ravi Bangoria
2020-03-09  8:57 ` [PATCH 08/15] powerpc/watchpoint: Disable all available watchpoints when !dawr_force_enable Ravi Bangoria
2020-03-09  8:57   ` Ravi Bangoria
2020-03-17 10:35   ` Christophe Leroy
2020-03-17 10:35     ` Christophe Leroy
2020-03-18  7:32     ` Ravi Bangoria
2020-03-18  7:32       ` Ravi Bangoria
2020-03-09  8:58 ` [PATCH 09/15] powerpc/watchpoint: Convert thread_struct->hw_brk to an array Ravi Bangoria
2020-03-09  8:58   ` Ravi Bangoria
2020-03-09 13:38   ` kbuild test robot
2020-03-17 10:37   ` Christophe Leroy
2020-03-17 10:37     ` Christophe Leroy
2020-03-18  8:36     ` Ravi Bangoria
2020-03-18  8:36       ` Ravi Bangoria
2020-03-18  8:56       ` Christophe Leroy
2020-03-18  8:56         ` Christophe Leroy
2020-03-18  9:22         ` Ravi Bangoria
2020-03-18  9:22           ` Ravi Bangoria
2020-03-09  8:58 ` [PATCH 10/15] powerpc/watchpoint: Use loop for thread_struct->ptrace_bps Ravi Bangoria
2020-03-09  8:58   ` Ravi Bangoria
2020-03-17 10:48   ` Christophe Leroy
2020-03-17 10:48     ` Christophe Leroy
2020-03-18  9:43     ` Ravi Bangoria
2020-03-18  9:43       ` Ravi Bangoria
2020-03-09  8:58 ` [PATCH 11/15] powerpc/watchpoint: Introduce is_ptrace_bp() function Ravi Bangoria
2020-03-09  8:58   ` Ravi Bangoria
2020-03-17 10:49   ` Christophe Leroy
2020-03-17 10:49     ` Christophe Leroy
2020-03-09  8:58 ` [PATCH 12/15] powerpc/watchpoint: Prepare handler to handle more than one watcnhpoint Ravi Bangoria
2020-03-09  8:58   ` Ravi Bangoria
2020-03-17 10:59   ` Christophe Leroy
2020-03-17 10:59     ` Christophe Leroy
2020-03-18 11:35     ` Michael Ellerman
2020-03-18 11:35       ` Michael Ellerman
2020-03-18 11:44       ` Christophe Leroy
2020-03-18 11:44         ` Christophe Leroy
2020-03-18 21:27         ` Segher Boessenkool
2020-03-18 21:27           ` Segher Boessenkool
2020-03-18 23:36           ` Michael Ellerman
2020-03-18 12:14     ` Ravi Bangoria
2020-03-18 12:14       ` Ravi Bangoria
2020-03-09  8:58 ` [PATCH 13/15] powerpc/watchpoint: Don't allow concurrent perf and ptrace events Ravi Bangoria
2020-03-09  8:58   ` Ravi Bangoria
2020-03-17 11:08   ` Christophe Leroy
2020-03-17 11:08     ` Christophe Leroy
2020-03-18 12:35     ` Ravi Bangoria
2020-03-18 12:35       ` Ravi Bangoria
2020-03-09  8:58 ` [PATCH 14/15] powerpc/watchpoint/xmon: Don't allow breakpoint overwriting Ravi Bangoria
2020-03-09  8:58   ` Ravi Bangoria
2020-03-17 11:10   ` Christophe Leroy
2020-03-17 11:10     ` Christophe Leroy
2020-03-18 12:37     ` Ravi Bangoria
2020-03-18 12:37       ` Ravi Bangoria
2020-03-18 13:31       ` Christophe Leroy
2020-03-18 13:31         ` Christophe Leroy
2020-03-09  8:58 ` [PATCH 15/15] powerpc/watchpoint/xmon: Support 2nd dawr Ravi Bangoria
2020-03-09  8:58   ` Ravi Bangoria
2020-03-17 11:14   ` Christophe Leroy
2020-03-17 11:14     ` Christophe Leroy
2020-03-18 12:39     ` Ravi Bangoria
2020-03-18 12:39       ` Ravi Bangoria
2020-03-16 15:05 ` [PATCH 00/15] powerpc/watchpoint: Preparation for more than one watchpoint Christophe Leroy
2020-03-16 15:05   ` Christophe Leroy
2020-03-16 18:43   ` Segher Boessenkool
2020-03-16 18:43     ` Segher Boessenkool
2020-03-17  5:56     ` Christophe Leroy
2020-03-17  5:56       ` Christophe Leroy
2020-03-18 12:52   ` Ravi Bangoria
2020-03-18 12:52     ` Ravi Bangoria
2020-03-23 13:37     ` Ravi Bangoria
2020-03-23 13:37       ` Ravi Bangoria

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200318183024.GJ22482@gate.crashing.org \
    --to=segher@kernel.crashing.org \
    --cc=apopple@linux.ibm.com \
    --cc=christophe.leroy@c-s.fr \
    --cc=fweisbec@gmail.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mikey@neuling.org \
    --cc=mingo@kernel.org \
    --cc=naveen.n.rao@linux.vnet.ibm.com \
    --cc=npiggin@gmail.com \
    --cc=oleg@redhat.com \
    --cc=paulus@samba.org \
    --cc=peterz@infradead.org \
    --cc=ravi.bangoria@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.