From: Marek Behun <marek.behun@nic.cz>
To: Chris Packham <Chris.Packham@alliedtelesis.co.nz>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"andrew@lunn.ch" <andrew@lunn.ch>
Subject: Re: [PATCH net-next] net: mvmdio: fix driver probe on missing irq
Date: Thu, 19 Mar 2020 05:36:59 +0100 [thread overview]
Message-ID: <20200319053659.4da19ae0@nic.cz> (raw)
In-Reply-To: <de28dd392987d666f9ad4a0c94e71fc0a686d8d6.camel@alliedtelesis.co.nz>
On Thu, 19 Mar 2020 04:27:56 +0000
Chris Packham <Chris.Packham@alliedtelesis.co.nz> wrote:
> On Thu, 2020-03-19 at 05:21 +0100, Marek Behun wrote:
> > On Thu, 19 Mar 2020 02:00:57 +0000
> > Chris Packham <Chris.Packham@alliedtelesis.co.nz> wrote:
> >
> > > Hi Marek,
> > >
> > > On Thu, 2020-03-19 at 02:29 +0100, Marek Behún wrote:
> > > > Commit e1f550dc44a4 made the use of platform_get_irq_optional, which can
> > > > return -ENXIO when interrupt is missing. Handle this as non-error,
> > > > otherwise the driver won't probe.
> > >
> > > This has already been fixed in net/master by reverting e1f550dc44a4 and
> > > replacing it with fa2632f74e57bbc869c8ad37751a11b6147a3acc.
> >
> > :( It isn't in net-next. I've spent like an hour debugging it :-D
>
> I can only offer my humble apologies and promise to do better next
> time. I did test the first minimally correct change, but clearly
> stuffed up on v2.
That's ok, but this should be also in net-next as well. Has Dave
forgotten to apply it there, or is there some other plan?
Marek
next prev parent reply other threads:[~2020-03-19 4:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-19 1:29 [PATCH net-next] net: mvmdio: fix driver probe on missing irq Marek Behún
2020-03-19 2:00 ` Chris Packham
2020-03-19 4:21 ` Marek Behun
2020-03-19 4:27 ` Chris Packham
2020-03-19 4:36 ` Marek Behun [this message]
2020-03-19 8:58 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200319053659.4da19ae0@nic.cz \
--to=marek.behun@nic.cz \
--cc=Chris.Packham@alliedtelesis.co.nz \
--cc=andrew@lunn.ch \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.