All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thierry Reding <treding@nvidia.com>
To: u-boot@lists.denx.de
Subject: [PATCH 1/2] net: rt8169: WAR for DHCP not getting IP after kernel boot/reboot
Date: Thu, 19 Mar 2020 09:03:39 +0100	[thread overview]
Message-ID: <20200319080339.GA2895039@ulmo> (raw)
In-Reply-To: <1584475636-24521-2-git-send-email-twarren@nvidia.com>

On Tue, Mar 17, 2020 at 01:07:15PM -0700, twarren at nvidia.com wrote:
> From: Tom Warren <twarren@nvidia.com>
> 
> This is a WAR for DHCP failure after rebooting from the L4T kernel. The
> r8169.c kernel driver is setting bit 19 of the rt816x HW register 0xF0,
> which goes by FuncEvent and MISC in various driver source/datasheets.
> That bit is called RxDv_Gated_En in the r8169.c kernel driver. Clear it
> here at the end of probe to ensure that U-Boot can get an IP assigned
> via DHCP.
> 
> Signed-off-by: Tom Warren <twarren@nvidia.com>
> ---
>  drivers/net/rtl8169.c | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)

Is this still needed? In my old p3450 branch that I worked on to get
Porg up and running I don't have this patch. It's also not in my local
development tree that I typically use to boot Tegra186 and earlier
boards. That branch works fine on the Jetson Nano, so I don't think this
is needed anymore. I vaguely recall that I determined that this was
fixed some other way, but unfortunately I don't remember the exact
details.

Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200319/f36936dc/attachment.sig>

  parent reply	other threads:[~2020-03-19  8:03 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-17 20:07 [PATCH 0/2] net: tegra: Misc network fixes twarren at nvidia.com
2020-03-17 20:07 ` [PATCH 1/2] net: rt8169: WAR for DHCP not getting IP after kernel boot/reboot twarren at nvidia.com
2020-03-18 23:29   ` Stephen Warren
2020-03-18 23:51     ` Tom Warren
2020-03-19  8:03   ` Thierry Reding [this message]
2020-03-19 15:42     ` Tom Warren
2020-03-17 20:07 ` [PATCH 2/2] tegra: Enable CONFIG_BOOTP_PREFER_SERVERIP for all boards twarren at nvidia.com
2020-03-18 23:31   ` Stephen Warren
2020-03-18 23:52     ` Tom Warren
2020-03-19  2:54       ` Stephen Warren
  -- strict thread matches above, loose matches on Subject: below --
2020-03-26 22:59 [PATCH 0/2] net: tegra: Misc network fixes tomcwarren3959 at gmail.com
2020-03-26 22:59 ` [PATCH 1/2] net: rt8169: WAR for DHCP not getting IP after kernel boot/reboot tomcwarren3959 at gmail.com
2020-06-12 21:15   ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200319080339.GA2895039@ulmo \
    --to=treding@nvidia.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.