From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: R Veera Kumar <vkor@vkten.in>
Cc: outreachy-kernel <outreachy-kernel@googlegroups.com>
Subject: Re: [Outreachy kernel] Re: [PATCH v2 0/4] Correction of typos in comments
Date: Thu, 19 Mar 2020 13:47:46 +0100 [thread overview]
Message-ID: <20200319124746.GA3955966@kroah.com> (raw)
In-Reply-To: <20200319124432.GA4276@tulip.local>
On Thu, Mar 19, 2020 at 06:14:33PM +0530, R Veera Kumar wrote:
> On Thu, Mar 19, 2020 at 01:14:07PM +0100, Greg Kroah-Hartman wrote:
> > On Thu, Mar 19, 2020 at 04:26:37PM +0530, R Veera Kumar wrote:
> > > Correct typos in comments.
> > > Misspellings found using checkpatch.pl
> > >
> > > ---
> > > R Veera Kumar (4):
> > > staging: rtl8723bs: os_dep: Correct typos in comments
> > > staging: rtl8723bs: os_dep: Correct typos in comments
> > > staging: rtl8723bs: os_dep: Correct typo in comment
> > > staging: rtl8723bs: os_dep: Correct typo in comment
> >
> > You need unique subject lines, please.
> >
>
> I do not know what to put.
> Should I put the file names in subject. Someone told not to do so.
> All the four patches correct one or two single letter misspellings
> in one or two comments.
>
> Can you give me a suggestion.
That is up to you. If you are not doing something unique in each
individual patch, then why did you think to break them up? If they are
not doing the same exact thing, then you should be able to describe them
in a unique way.
good luck!
greg k-h
prev parent reply other threads:[~2020-03-19 12:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-19 10:56 [PATCH v2 0/4] Correction of typos in comments R Veera Kumar
2020-03-19 10:56 ` [PATCH v2 1/4] staging: rtl8723bs: os_dep: Correct " R Veera Kumar
2020-03-19 10:56 ` [PATCH v2 2/4] " R Veera Kumar
2020-03-19 10:56 ` [PATCH v2 3/4] staging: rtl8723bs: os_dep: Correct typo in comment R Veera Kumar
2020-03-19 10:56 ` [PATCH v2 4/4] " R Veera Kumar
2020-03-19 12:14 ` [PATCH v2 0/4] Correction of typos in comments Greg Kroah-Hartman
2020-03-19 12:44 ` [Outreachy kernel] " R Veera Kumar
2020-03-19 12:47 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200319124746.GA3955966@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=outreachy-kernel@googlegroups.com \
--cc=vkor@vkten.in \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.