Re: [PATCH] staging: sm750fb: rearrange line exceeding 80 characters

[Greg KH <gregkh@linuxfoundation.org>]

On Thu, Mar 19, 2020 at 05:16:12PM +0300, Gokce Kuler wrote:
> Moved to the bottom line after << operator for it exceeds 80 character
> 
> Signed-off-by: Gokce Kuler <gokcekuler@gmail.com>
> ---
>  drivers/staging/sm750fb/sm750_cursor.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/sm750fb/sm750_cursor.c b/drivers/staging/sm750fb/sm750_cursor.c
> index bbbef27..b67c545 100644
> --- a/drivers/staging/sm750fb/sm750_cursor.c
> +++ b/drivers/staging/sm750fb/sm750_cursor.c
> @@ -116,7 +116,8 @@ void sm750_hw_cursor_setData(struct lynx_cursor *cursor, u16 rop,
>  					opr = mask & color;
>  
>  				/* 2 stands for forecolor and 1 for backcolor */
> -				data |= ((opr & (0x80 >> j)) ? 2 : 1) << (j * 2);
> +				data |= ((opr & (0x80 >> j)) ? 2 : 1) <<
> +				       	(j * 2);

The original code is much easier to understand and read, please leave it
as-is.

Remember, checkpatch is just a hint, not always a hard-rule.

thanks,

greg k-h