Re: [Outreachy kernel] [RESEND PATCH 00/10] Correction of typos and long lines of comments

[R Veera Kumar <vkor@vkten.in>]

On Thu, Mar 19, 2020 at 04:58:05PM +0100, Julia Lawall wrote:
> 
> 
> On Thu, 19 Mar 2020, R Veera Kumar wrote:
> 
> > Correction of typos and long lines of comments.
> > Misspellings found using checkpatch.pl.
> >
> > ---
> > R Veera Kumar (10):
> >   staging: rtl8723bs: hal: Correct a typo in a comment
> >   staging: rtl8723bs: hal: Correct a typo in a comment
> 
> Maybe you could just put all the typo ones in a single patch?  They should
> be easy to check and have no impact on the execution, so it is hard to see
> why one would want to revert them separately.
>

Yes. That's what he meant in reply. But I did otherwise because in my
first patch to mailing list I had typos in two different files. I sent
it as single patch and he accepted. And the I asked him whether it could
have been sent as patchset, and he said yes.

Now reading submitting-patches doc it says if it is single kind of
change then it should be put in one patch. And only if it is logically
different then in two separate patches.

> On the other hand, the patch would be just typos, not long line changes
> mixed in as well.
> 

Yeah.

Veera

> julia
> 
> >
> >  drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c |  2 +-
> >  drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.c |  2 +-
> >  drivers/staging/rtl8723bs/hal/HalPhyRf.c        |  7 +++++--
> >  10 files changed, 27 insertions(+), 18 deletions(-)
> >