From: Guenter Roeck <linux@roeck-us.net>
To: Grant Peltier <grantpeltier93@gmail.com>
Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org,
adam.vaughn.xh@renesas.com
Subject: Re: [PATCH v2 1/2] hwmon: (pmbus) add support for 2nd Gen Renesas digital multiphase
Date: Thu, 19 Mar 2020 20:02:42 -0700 [thread overview]
Message-ID: <20200320030242.GA2413@roeck-us.net> (raw)
In-Reply-To: <10f2ef1746e5d079ac3b3c6054ffd2bbfc314572.1584568073.git.grantpeltier93@gmail.com>
On Thu, Mar 19, 2020 at 10:49:50AM -0500, Grant Peltier wrote:
> Extend the isl68137 driver to provide support for 2nd generation Renesas
> digital multiphase voltage regulators.
>
> Signed-off-by: Grant Peltier <grantpeltier93@gmail.com>
I hate to (have to) say that, but there are lots of checkpatch errors and
warnings in this patch.
total: 7 errors, 4 warnings, 182 lines checked
That is really unnecessary. Please fix and resubmit.
Thanks,
Guenter
next prev parent reply other threads:[~2020-03-20 3:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-19 15:49 [PATCH v2 0/2] hwmon: (pmbus) add support for Gen 2 Renesas digital multiphase Grant Peltier
2020-03-19 15:49 ` [PATCH v2 1/2] hwmon: (pmbus) add support for 2nd Gen " Grant Peltier
2020-03-20 3:02 ` Guenter Roeck [this message]
2020-03-19 15:50 ` [PATCH v2 2/2] docs: hwmon: Update documentation for isl68137 pmbus driver Grant Peltier
2020-03-20 3:05 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200320030242.GA2413@roeck-us.net \
--to=linux@roeck-us.net \
--cc=adam.vaughn.xh@renesas.com \
--cc=grantpeltier93@gmail.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.