From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31C86C4332E for ; Fri, 20 Mar 2020 07:00:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EA85B20775 for ; Fri, 20 Mar 2020 07:00:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584687618; bh=Wx2NDRaC1QOdWxleWTMWNTMNxcUwA7KWDbnvfFS0LDQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=PJFZ6qusxINR/LMHFNUm7t1XxYBkaKbBrOVcaDtGbEWsDg97klQPHuwGrAZQOoqFK hfghebKMraFp52tLCT1km0hEHrHYWhVzb3xY2uSk4o4Q55xu+Om1lpWj/Wj6df/3VQ b8w31wlT4tCgEQRCXbGCI7mYgXhe6vhPanlcsTws= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726884AbgCTHAR (ORCPT ); Fri, 20 Mar 2020 03:00:17 -0400 Received: from mail.kernel.org ([198.145.29.99]:59302 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726030AbgCTHAR (ORCPT ); Fri, 20 Mar 2020 03:00:17 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 674D320774; Fri, 20 Mar 2020 07:00:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584687616; bh=Wx2NDRaC1QOdWxleWTMWNTMNxcUwA7KWDbnvfFS0LDQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=T3GLF4ReYRXEGtgMaJH6bIWeZqh4swar4eDyLwC1tXgWSsnJZq7axU4qvLBeq2fUj oiMhPMNaNCZDFLKTAuhwwjDR6442ZZ/+RQG8b5Q3/t4TA0yhiLqtF6wuHr8WZ9es7L KNzfddH4n/Etw6SyXHgGDTpsC1TWFp6RyAivoZio= Date: Fri, 20 Mar 2020 07:59:50 +0100 From: Greg KH To: Gokce Kuler Cc: outreachy-kernel@googlegroups.com, linux-usb@vger.kernel.org Subject: Re: [PATCH 0/2] Avoid multiple line dereference Message-ID: <20200320065950.GC307955@kroah.com> References: <20200320065906.GB307955@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200320065906.GB307955@kroah.com> Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Fri, Mar 20, 2020 at 07:59:06AM +0100, Greg KH wrote: > On Fri, Mar 20, 2020 at 05:03:03AM +0300, Gokce Kuler wrote: > > merge a line -> with a line ending with a sign > > > > merge a line -> with a line ending with a sign > > > > Gokce Kuler (2): > > staging: rtl8712: Avoid multiple line dereference > > staging: rtl8712: Avoid multiple line dereference > > You should put the subsystem and driver in this 0/2 email subject as > well. > > But the big problem of this (have you been reading other patch > submissions here?) is that you sent 2 patches that did different things, > yet had the same subject line, which is not ok. > > Please make them unique. And why is this 2 patches anyway? SHouldn't it just be 1 patch as you are doing 1 logical thing to the file? Do not make multiple patches were a single one is all that is needed. thanks, greg k-h