From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Sasha Levin <sashal@kernel.org>,
Anders Roxell <anders.roxell@linaro.org>,
Faiz Abbas <faiz_abbas@ti.com>, Peter Geis <pgwipeout@gmail.com>,
Sowjanya Komatineni <skomatineni@nvidia.com>,
"# 4.0+" <stable@vger.kernel.org>,
Naresh Kamboju <naresh.kamboju@linaro.org>
Subject: Re: FAILED: patch "[PATCH] mmc: core: Allow host controllers to require R1B for CMD6" failed to apply to 5.5-stable tree
Date: Fri, 20 Mar 2020 10:50:35 +0100 [thread overview]
Message-ID: <20200320095035.GC421650@kroah.com> (raw)
In-Reply-To: <CAPDyKFp2zX5Zij4bCRuOrxBzgpyH9n2Ee3rNBVkm46n8R5DfNA@mail.gmail.com>
On Fri, Mar 20, 2020 at 10:12:15AM +0100, Ulf Hansson wrote:
> + Naresh
>
> On Wed, 18 Mar 2020 at 20:25, Sasha Levin <sashal@kernel.org> wrote:
> >
> > On Mon, Mar 16, 2020 at 12:31:18PM +0100, gregkh@linuxfoundation.org wrote:
> > >
> > >The patch below does not apply to the 5.5-stable tree.
> > >If someone wants it applied there, or to any other stable or longterm
> > >tree, then please email the backport, including the original git commit
> > >id to <stable@vger.kernel.org>.
> > >
> > >thanks,
> > >
> > >greg k-h
> > >
> > >------------------ original commit in Linus's tree ------------------
> > >
> > >From 1292e3efb149ee21d8d33d725eeed4e6b1ade963 Mon Sep 17 00:00:00 2001
> > >From: Ulf Hansson <ulf.hansson@linaro.org>
> > >Date: Tue, 10 Mar 2020 12:49:43 +0100
> > >Subject: [PATCH] mmc: core: Allow host controllers to require R1B for CMD6
> > >
> > >It has turned out that some host controllers can't use R1B for CMD6 and
> > >other commands that have R1B associated with them. Therefore invent a new
> > >host cap, MMC_CAP_NEED_RSP_BUSY to let them specify this.
> > >
> > >In __mmc_switch(), let's check the flag and use it to prevent R1B responses
> > >from being converted into R1. Note that, this also means that the host are
> > >on its own, when it comes to manage the busy timeout.
> > >
> > >Suggested-by: Sowjanya Komatineni <skomatineni@nvidia.com>
> > >Cc: <stable@vger.kernel.org>
> > >Tested-by: Anders Roxell <anders.roxell@linaro.org>
> > >Tested-by: Sowjanya Komatineni <skomatineni@nvidia.com>
> > >Tested-by: Faiz Abbas <faiz_abbas@ti.com>
> > >Tested-By: Peter Geis <pgwipeout@gmail.com>
> > >Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
> >
> > I've fixed up and queued this whole mmc series of stable tagged patches
> > for 4.19-5.5.
>
> I looked at stable-rc tree and realized that you have also picked the
> following patch:
>
> commit 533a6cfe08f96a7b5c65e06d20916d552c11b256
> Author: Ulf Hansson <ulf.hansson@linaro.org>
> Date: Wed Jan 22 15:27:47 2020 +0100
> mmc: core: Default to generic_cmd6_time as timeout in __mmc_switch()
>
> I assume this one was needed to apply the others mmc patches on top.
> This is a problem, because the above patch should not go for stable as
> it causes problems (unless additional patches are backported as well).
>
> I suggest to drop the whole slew of mmc patches for the current stable
> rcs. Then I can send manual backports instead, is that okay?
Yes, I have now done that, having a properly backported set of patches
would be great, thanks!
greg k-h
prev parent reply other threads:[~2020-03-20 9:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-16 11:31 FAILED: patch "[PATCH] mmc: core: Allow host controllers to require R1B for CMD6" failed to apply to 5.5-stable tree gregkh
2020-03-18 19:25 ` Sasha Levin
2020-03-20 9:12 ` Ulf Hansson
2020-03-20 9:50 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200320095035.GC421650@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=anders.roxell@linaro.org \
--cc=faiz_abbas@ti.com \
--cc=naresh.kamboju@linaro.org \
--cc=pgwipeout@gmail.com \
--cc=sashal@kernel.org \
--cc=skomatineni@nvidia.com \
--cc=stable@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.