From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v4 3/3] Add connection tests for bind()
Date: Fri, 20 Mar 2020 10:53:12 +0100 [thread overview]
Message-ID: <20200320095312.GC12179@dell5510> (raw)
In-Reply-To: <20200317121057.13529-3-mdoucha@suse.cz>
Hi Martin,
> + SAFE_LISTEN(listen_sock, 1);
> + SAFE_PTHREAD_CREATE(&thread_id, NULL, peer_thread, &tc_copy);
> + sock = accept(listen_sock, (struct sockaddr *)&remote_addr,
> + &remote_len);
> +
> + if (sock < 0)
> + tst_brk(TBROK | TERRNO, "accept() failed");
We can just use
sock = SAFE_ACCEPT(listen_sock, (struct sockaddr *)&remote_addr,
&remote_len);
Whole patch set looks ok to me.
Reviewed-by: Petr Vorel <pvorel@suse.cz>
Kind regards,
Petr
next prev parent reply other threads:[~2020-03-20 9:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-17 12:10 [LTP] [PATCH v4 1/3] Create separate .c file for include/tst_net.h Martin Doucha
2020-03-17 12:10 ` [LTP] [PATCH v4 2/3] Add socket address initialization functions to tst_net library Martin Doucha
2020-03-20 9:03 ` Petr Vorel
2020-03-20 9:44 ` Martin Doucha
2020-03-20 9:22 ` Petr Vorel
2020-03-17 12:10 ` [LTP] [PATCH v4 3/3] Add connection tests for bind() Martin Doucha
2020-03-20 8:54 ` Petr Vorel
2020-03-20 9:43 ` Martin Doucha
2020-03-20 11:18 ` Petr Vorel
2020-03-20 9:53 ` Petr Vorel [this message]
2020-03-17 20:03 ` [LTP] [PATCH v4 1/3] Create separate .c file for include/tst_net.h Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200320095312.GC12179@dell5510 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.