From: Mauro Carvalho Chehab <mchehab@kernel.org>
To: Martin Knoblauch <knobi@knobisoft.de>
Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org
Subject: Re: Build error on 5.5.10 after activating v4l in .config
Date: Fri, 20 Mar 2020 16:13:01 +0100 [thread overview]
Message-ID: <20200320161301.36866c31@coco.lan> (raw)
In-Reply-To: <CAJtcoLYiGLa3UWQ-XBVc=ATQEnsFrfZuU0i_fS22b7Uv+S-Ysw@mail.gmail.com>
Em Fri, 20 Mar 2020 15:56:16 +0100
Martin Knoblauch <knobi@knobisoft.de> escreveu:
> Hi, (sesending without attachment)
>
> today I tried to build 5.5.10 based on a working 5.5.6 configuration. I
> also enabled v4l in the configuration using menuconfig. This resulted in
> the following build error:
>
> AS arch/x86/boot/compressed/efi_thunk_64.o
> CC arch/x86/boot/compressed/misc.o
> XZKERN arch/x86/boot/compressed/vmlinux.bin.xz
> ERROR: "__devm_regmap_init_i2c" [drivers/media/i2c/tvp5150.ko] undefined!
> make[1]: *** [scripts/Makefile.modpost:94: __modpost] Error 1
> make: *** [Makefile:1282: modules] Error 2
> make: *** Waiting for unfinished jobs....
>
> After some searching the universal support tool, I applied the following
> patch:
>
> --- ./drivers/media/i2c/Kconfig-orig 2020-03-18 13:57:30.288639392 +0100
> +++ ./drivers/media/i2c/Kconfig 2020-03-18 16:44:03.938384192 +0100
> @@ -378,6 +378,7 @@
> config VIDEO_TVP5150
> tristate "Texas Instruments TVP5150 video decoder"
> depends on VIDEO_V4L2 && I2C
> + select REGMAP_I2C
> select V4L2_FWNODE
> help
> Support for the Texas Instruments TVP5150 video decoder.
>
> This made my build work again. But I am absolutely not sure this is the
> right fix or whether it is complete.
Yes, it is. There are other places where the same select is needed.
There's already a patch upstream (linux-next) addressing this issue.
It should be merged for 5.7.
Regards,
Mauro
next parent reply other threads:[~2020-03-20 15:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAJtcoLYiGLa3UWQ-XBVc=ATQEnsFrfZuU0i_fS22b7Uv+S-Ysw@mail.gmail.com>
2020-03-20 15:13 ` Mauro Carvalho Chehab [this message]
[not found] ` <CAJtcoLZKbiSqRPvLMz-Bp142sxEFhuAkbZzx7P3n3VW2bNCtQA@mail.gmail.com>
2020-03-23 10:21 ` Build error on 5.5.10 after activating v4l in .config Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200320161301.36866c31@coco.lan \
--to=mchehab@kernel.org \
--cc=knobi@knobisoft.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.