All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Corbet <corbet@lwn.net>
To: Wang Wenhu <wenhu.wang@vivo.com>
Cc: Harry Wei <harryxiyou@gmail.com>,
	Alex Shi <alex.shi@linux.alibaba.com>,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel@vivo.com
Subject: Re: [PATCH v2,RESEND] doc: zh_CN: fix style problems for io_ordering.txt
Date: Fri, 20 Mar 2020 17:24:26 -0600	[thread overview]
Message-ID: <20200320172426.121d881d@lwn.net> (raw)
In-Reply-To: <20200315060857.82880-1-wenhu.wang@vivo.com>

On Sat, 14 Mar 2020 23:08:55 -0700
Wang Wenhu <wenhu.wang@vivo.com> wrote:

> Problems exist in the Chinese translation of io_ordering.txt.
> Partly for the difference between Chinese and English character
> encoding format, and the others are of the failure to comply
> with the ReST markups.

So I feel like I'm missing something here...

> Signed-off-by: Wang Wenhu <wenhu.wang@vivo.com>
> ---
> v2: resend for the failure of delivering.
> 
>  .../translations/zh_CN/io_ordering.txt        | 72 ++++++++++++-------
>  1 file changed, 46 insertions(+), 26 deletions(-)
> 
> diff --git a/Documentation/translations/zh_CN/io_ordering.txt b/Documentation/translations/zh_CN/io_ordering.txt
> index 1f8127bdd415..080ed2911db0 100644
> --- a/Documentation/translations/zh_CN/io_ordering.txt
> +++ b/Documentation/translations/zh_CN/io_ordering.txt
> @@ -29,39 +29,59 @@ Documentation/io_ordering.txt 的中文翻译
>  这也可以保证后面的写操作只在前面的写操作之后到达设备(这非常类似于内存
>  屏障操作,mb(),不过仅适用于I/O)。
>  
> +A more concrete example from a hypothetical device driver::
> +
> +		...
> +	CPU A:  spin_lock_irqsave(&dev_lock, flags)
> +	CPU A:  val = readl(my_status);
> +	CPU A:  ...
> +	CPU A:  writel(newval, ring_ptr);
> +	CPU A:  spin_unlock_irqrestore(&dev_lock, flags)
> +		...
> +	CPU B:  spin_lock_irqsave(&dev_lock, flags)
> +	CPU B:  val = readl(my_status);
> +	CPU B:  ...
> +	CPU B:  writel(newval2, ring_ptr);
> +	CPU B:  spin_unlock_irqrestore(&dev_lock, flags)
> +		...
> +
> +
>  假设一个设备驱动程的具体例子:
> +::
>  
> +		...
> +	CPU A:  spin_lock_irqsave(&dev_lock, flags)
> +	CPU A:  val = readl(my_status);
> +	CPU A:  ...
> +	CPU A:  writel(newval, ring_ptr);
> +	CPU A:  spin_unlock_irqrestore(&dev_lock, flags)
> +		...
> +	CPU B:  spin_lock_irqsave(&dev_lock, flags)
> +	CPU B:  val = readl(my_status);
> +	CPU B:  ...
> +	CPU B:  writel(newval2, ring_ptr);
> +	CPU B:  spin_unlock_irqrestore(&dev_lock, flags)

It sure looks like you're adding the same text twice here...?

Thanks,

jon


  reply	other threads:[~2020-03-20 23:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-15  6:08 [PATCH v2,RESEND] doc: zh_CN: fix style problems for io_ordering.txt Wang Wenhu
2020-03-20 23:24 ` Jonathan Corbet [this message]
2020-03-21  7:40   ` 王文虎

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200320172426.121d881d@lwn.net \
    --to=corbet@lwn.net \
    --cc=alex.shi@linux.alibaba.com \
    --cc=harryxiyou@gmail.com \
    --cc=kernel@vivo.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=wenhu.wang@vivo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.