From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C44A8C4332D for ; Fri, 20 Mar 2020 17:33:18 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2C2A520722 for ; Fri, 20 Mar 2020 17:33:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="Ul9UXhZk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2C2A520722 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 5F5DE3E; Fri, 20 Mar 2020 18:32:26 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 5F5DE3E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1584725596; bh=WsjgjMc5V84hg2ru5hJzn4ARjRe9A0ITrIl/CNrlPLg=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=Ul9UXhZkQcE8Y8MKcXmB99b5Rx7S0Mb4KdOy/ETROMs92WjeLdWBSTEhXuj5DPSUX i6HY5+JfNcBWtVRohtdRAKDPTjD20qHbWh21+8gS/ywWxkxSMNAKRV1SExBTMwfDWe viMfEX91rqwPoNVI4INgKQv65pKDbmhfMLk7Y+/w= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id C58B9F80139; Fri, 20 Mar 2020 18:32:25 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 2F63EF8015B; Fri, 20 Mar 2020 18:32:23 +0100 (CET) Received: from mail-il1-f193.google.com (mail-il1-f193.google.com [209.85.166.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 214ABF800DD for ; Fri, 20 Mar 2020 18:32:18 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 214ABF800DD Received: by mail-il1-f193.google.com with SMTP id r5so1623432ilq.6 for ; Fri, 20 Mar 2020 10:32:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=FXIfsAVUFp8IJFPm+/hNheLawxwEVeZKgbspez8Hy3A=; b=JJ8Hk0sqc4Q8Yh7cbEInCvh5yyAlXLvAuAfZmSt7Dst+X4S1Jncb2Huuuf7W569nwO 2WOEOSYvhBLopIZJy7Tie4aBoYCavXIrVTFbv4tJv+orXOCnBx5jnyr6qXa1O/D9OQkr /t4u8ZX6gMznRVNJu30BFbNPAAyHslTNM3xFzcxS0DCjNW2zPpWn6sZAS6BkPfpc5lGW OE15s0JeWevDN+ECsEmQ3bkPCnQ0ULu6N7hsevetrwXxret0Up7vCeQlF3AsurWnn5Va QT40ffTopfZH1FH+PH2VXl0q0wKM/H48QWRCrAJ0M1JH/PyPaFXMZklT16icXoQ9cKPV 0SRA== X-Gm-Message-State: ANhLgQ2itePzEsLyjBlWXaRJA2I7hIDyekYXJ4G6Pu4jxmnqhGaV2e+7 ZgBRncyWFSx3XIjmtRBRkg== X-Google-Smtp-Source: ADFU+vvyOEHh52ksLg64oqQQtskIyPgC3Gb9PgcVjz3NdBpqcYEYi8YkzZvcjgp/TY2ZkGE4F1dg5g== X-Received: by 2002:a92:d641:: with SMTP id x1mr9850010ilp.223.1584725536379; Fri, 20 Mar 2020 10:32:16 -0700 (PDT) Received: from rob-hp-laptop ([64.188.179.250]) by smtp.gmail.com with ESMTPSA id j23sm1874792ioa.10.2020.03.20.10.32.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Mar 2020 10:32:15 -0700 (PDT) Received: (nullmailer pid 16573 invoked by uid 1000); Fri, 20 Mar 2020 17:32:13 -0000 Date: Fri, 20 Mar 2020 11:32:13 -0600 From: Rob Herring To: Nicolin Chen Subject: Re: [PATCH v5 1/7] ASoC: dt-bindings: fsl_asrc: Add new property fsl,asrc-format Message-ID: <20200320173213.GA9093@bogus> References: <24f69c50925b93afd7a706bd888ee25d27247c78.1583725533.git.shengjiu.wang@nxp.com> <20200309211943.GB11333@Asurada-Nvidia.nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200309211943.GB11333@Asurada-Nvidia.nvidia.com> User-Agent: Mutt/1.10.1 (2018-07-13) Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, alsa-devel@alsa-project.org, timur@kernel.org, Xiubo.Lee@gmail.com, linuxppc-dev@lists.ozlabs.org, Shengjiu Wang , tiwai@suse.com, lgirdwood@gmail.com, broonie@kernel.org, festevam@gmail.com, linux-kernel@vger.kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Mon, Mar 09, 2020 at 02:19:44PM -0700, Nicolin Chen wrote: > On Mon, Mar 09, 2020 at 11:58:28AM +0800, Shengjiu Wang wrote: > > In order to support new EASRC and simplify the code structure, > > We decide to share the common structure between them. This bring > > a problem that EASRC accept format directly from devicetree, but > > ASRC accept width from devicetree. > > > > In order to align with new ESARC, we add new property fsl,asrc-format. > > The fsl,asrc-format can replace the fsl,asrc-width, then driver > > can accept format from devicetree, don't need to convert it to > > format through width. > > > > Signed-off-by: Shengjiu Wang > > --- > > Documentation/devicetree/bindings/sound/fsl,asrc.txt | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/sound/fsl,asrc.txt b/Documentation/devicetree/bindings/sound/fsl,asrc.txt > > index cb9a25165503..780455cf7f71 100644 > > --- a/Documentation/devicetree/bindings/sound/fsl,asrc.txt > > +++ b/Documentation/devicetree/bindings/sound/fsl,asrc.txt > > @@ -51,6 +51,11 @@ Optional properties: > > will be in use as default. Otherwise, the big endian > > mode will be in use for all the device registers. > > > > + - fsl,asrc-format : Defines a mutual sample format used by DPCM Back > > + Ends, which can replace the fsl,asrc-width. > > + The value is SNDRV_PCM_FORMAT_S16_LE, or > > + SNDRV_PCM_FORMAT_S24_LE > > I am still holding the concern at the DT binding of this format, > as it uses values from ASoC header file instead of a dt-binding > header file -- not sure if we can do this. Let's wait for Rob's > comments. I assume those are an ABI as well, so it's okay to copy them unless we already have some format definitions for DT. But it does need to be copy in a header under include/dt-bindings/. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCF77C4332D for ; Fri, 20 Mar 2020 17:34:05 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7751520722 for ; Fri, 20 Mar 2020 17:34:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7751520722 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 48kW972hc6zDrdL for ; Sat, 21 Mar 2020 04:34:03 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=209.85.166.193; helo=mail-il1-f193.google.com; envelope-from=robherring2@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=fail (p=none dis=none) header.from=kernel.org Received: from mail-il1-f193.google.com (mail-il1-f193.google.com [209.85.166.193]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 48kW780vCbzDvgD for ; Sat, 21 Mar 2020 04:32:19 +1100 (AEDT) Received: by mail-il1-f193.google.com with SMTP id d14so6324377ilq.10 for ; Fri, 20 Mar 2020 10:32:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=FXIfsAVUFp8IJFPm+/hNheLawxwEVeZKgbspez8Hy3A=; b=dkT66fhUD4EW2m3ZMh2GRlGj4FSFmY5TC1QgD7OYqDy07mTaua1z8DARI4prWbIuEO +lEzPRay8V/fDHHgVodoLSiLB3J2yIywZBGL9Rg0hy9ayCcwxpRyjo611rLNLedbVtDd PKPWBYwx+BZrjmLRZ6fyhxcS6dTOJXSP3QVB7E1mftU8GooKLgnYCY3YcC1XznKeBx5J DcdAvaieBwiR9N5XX8GLruGEdIF0G1F5a6zkjV9pd99TPl7fudwzE2nBWbuzqfWwUq07 fUikFbq/3rzAsnP6Yc7ffKpkd2NgQiaEh9CMbkHZEjsXgyppFykO3e1ogtTDyAiNTMTf MOHg== X-Gm-Message-State: ANhLgQ0WPpvbgvzqRLDSz+z3mdG5A3WNrUF5EPLaaNd/MX5lsIi+kRuy hRce1CZjZrx3ZNS5GMS98g== X-Google-Smtp-Source: ADFU+vvyOEHh52ksLg64oqQQtskIyPgC3Gb9PgcVjz3NdBpqcYEYi8YkzZvcjgp/TY2ZkGE4F1dg5g== X-Received: by 2002:a92:d641:: with SMTP id x1mr9850010ilp.223.1584725536379; Fri, 20 Mar 2020 10:32:16 -0700 (PDT) Received: from rob-hp-laptop ([64.188.179.250]) by smtp.gmail.com with ESMTPSA id j23sm1874792ioa.10.2020.03.20.10.32.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Mar 2020 10:32:15 -0700 (PDT) Received: (nullmailer pid 16573 invoked by uid 1000); Fri, 20 Mar 2020 17:32:13 -0000 Date: Fri, 20 Mar 2020 11:32:13 -0600 From: Rob Herring To: Nicolin Chen Subject: Re: [PATCH v5 1/7] ASoC: dt-bindings: fsl_asrc: Add new property fsl,asrc-format Message-ID: <20200320173213.GA9093@bogus> References: <24f69c50925b93afd7a706bd888ee25d27247c78.1583725533.git.shengjiu.wang@nxp.com> <20200309211943.GB11333@Asurada-Nvidia.nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200309211943.GB11333@Asurada-Nvidia.nvidia.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, alsa-devel@alsa-project.org, timur@kernel.org, Xiubo.Lee@gmail.com, linuxppc-dev@lists.ozlabs.org, Shengjiu Wang , tiwai@suse.com, lgirdwood@gmail.com, perex@perex.cz, broonie@kernel.org, festevam@gmail.com, linux-kernel@vger.kernel.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Mon, Mar 09, 2020 at 02:19:44PM -0700, Nicolin Chen wrote: > On Mon, Mar 09, 2020 at 11:58:28AM +0800, Shengjiu Wang wrote: > > In order to support new EASRC and simplify the code structure, > > We decide to share the common structure between them. This bring > > a problem that EASRC accept format directly from devicetree, but > > ASRC accept width from devicetree. > > > > In order to align with new ESARC, we add new property fsl,asrc-format. > > The fsl,asrc-format can replace the fsl,asrc-width, then driver > > can accept format from devicetree, don't need to convert it to > > format through width. > > > > Signed-off-by: Shengjiu Wang > > --- > > Documentation/devicetree/bindings/sound/fsl,asrc.txt | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/sound/fsl,asrc.txt b/Documentation/devicetree/bindings/sound/fsl,asrc.txt > > index cb9a25165503..780455cf7f71 100644 > > --- a/Documentation/devicetree/bindings/sound/fsl,asrc.txt > > +++ b/Documentation/devicetree/bindings/sound/fsl,asrc.txt > > @@ -51,6 +51,11 @@ Optional properties: > > will be in use as default. Otherwise, the big endian > > mode will be in use for all the device registers. > > > > + - fsl,asrc-format : Defines a mutual sample format used by DPCM Back > > + Ends, which can replace the fsl,asrc-width. > > + The value is SNDRV_PCM_FORMAT_S16_LE, or > > + SNDRV_PCM_FORMAT_S24_LE > > I am still holding the concern at the DT binding of this format, > as it uses values from ASoC header file instead of a dt-binding > header file -- not sure if we can do this. Let's wait for Rob's > comments. I assume those are an ABI as well, so it's okay to copy them unless we already have some format definitions for DT. But it does need to be copy in a header under include/dt-bindings/. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00C40C4332B for ; Fri, 20 Mar 2020 17:32:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CC59920775 for ; Fri, 20 Mar 2020 17:32:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584725537; bh=WsjgjMc5V84hg2ru5hJzn4ARjRe9A0ITrIl/CNrlPLg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=D3mAmnahsAZhHimAn6dQXtooiYnxREp46H0HNJDUAY5k/FyEdIH4xOLSlgBuZ4LZg TOYN6gkaGJB3QEy488G+Zlf9zVwzwzffTEgvgQhY4i3wZZK2EPZWPWj++1/n5n37K8 J8OlWqYpVKCYYvYww8mCoX2hXvDr1QJn6t+8n6EI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726913AbgCTRcR (ORCPT ); Fri, 20 Mar 2020 13:32:17 -0400 Received: from mail-il1-f193.google.com ([209.85.166.193]:46100 "EHLO mail-il1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726847AbgCTRcR (ORCPT ); Fri, 20 Mar 2020 13:32:17 -0400 Received: by mail-il1-f193.google.com with SMTP id e8so6291093ilc.13; Fri, 20 Mar 2020 10:32:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=FXIfsAVUFp8IJFPm+/hNheLawxwEVeZKgbspez8Hy3A=; b=NV3q3F1RHAx2DDPQw5wFD8USkxgiYFTwB5BS3nBhoVdgwYTQRjJbamA1hzpGltxNFf ne2Lpf4uE0E2ot/MYx9OW/HsaTjLjyjsUhAIbXdEx22yXe1YVBhqUQCei6xwH/WZlbXs lsFsli4akYyzSqVyu6Z/FP8CfOUyTapktNXPay9blnkEqIk0hsCucoFagE5y7DIK/O7Z FJCx/XQjYbylHp+f2nxDnvn3j4c8A9B4YNguLfVhYWkonPJPzbLhRO7jWe31+MfxIRbs XT3O3ktDy6SvImTjaUN/FyfYG94n70Yv0u+T9kfn9ZDHoMlfzgVD9np56VBMbQ0aSpcy a03w== X-Gm-Message-State: ANhLgQ2R1qWVSWtLIBIKLHRPFqm40Bc4HB1hk5C/6CtkgSFjJ26LqgEb ObDHluqKj6RF3seZ+Pj3sg== X-Google-Smtp-Source: ADFU+vvyOEHh52ksLg64oqQQtskIyPgC3Gb9PgcVjz3NdBpqcYEYi8YkzZvcjgp/TY2ZkGE4F1dg5g== X-Received: by 2002:a92:d641:: with SMTP id x1mr9850010ilp.223.1584725536379; Fri, 20 Mar 2020 10:32:16 -0700 (PDT) Received: from rob-hp-laptop ([64.188.179.250]) by smtp.gmail.com with ESMTPSA id j23sm1874792ioa.10.2020.03.20.10.32.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Mar 2020 10:32:15 -0700 (PDT) Received: (nullmailer pid 16573 invoked by uid 1000); Fri, 20 Mar 2020 17:32:13 -0000 Date: Fri, 20 Mar 2020 11:32:13 -0600 From: Rob Herring To: Nicolin Chen Cc: Shengjiu Wang , timur@kernel.org, Xiubo.Lee@gmail.com, festevam@gmail.com, broonie@kernel.org, alsa-devel@alsa-project.org, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, mark.rutland@arm.com, devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 1/7] ASoC: dt-bindings: fsl_asrc: Add new property fsl,asrc-format Message-ID: <20200320173213.GA9093@bogus> References: <24f69c50925b93afd7a706bd888ee25d27247c78.1583725533.git.shengjiu.wang@nxp.com> <20200309211943.GB11333@Asurada-Nvidia.nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200309211943.GB11333@Asurada-Nvidia.nvidia.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, Mar 09, 2020 at 02:19:44PM -0700, Nicolin Chen wrote: > On Mon, Mar 09, 2020 at 11:58:28AM +0800, Shengjiu Wang wrote: > > In order to support new EASRC and simplify the code structure, > > We decide to share the common structure between them. This bring > > a problem that EASRC accept format directly from devicetree, but > > ASRC accept width from devicetree. > > > > In order to align with new ESARC, we add new property fsl,asrc-format. > > The fsl,asrc-format can replace the fsl,asrc-width, then driver > > can accept format from devicetree, don't need to convert it to > > format through width. > > > > Signed-off-by: Shengjiu Wang > > --- > > Documentation/devicetree/bindings/sound/fsl,asrc.txt | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/sound/fsl,asrc.txt b/Documentation/devicetree/bindings/sound/fsl,asrc.txt > > index cb9a25165503..780455cf7f71 100644 > > --- a/Documentation/devicetree/bindings/sound/fsl,asrc.txt > > +++ b/Documentation/devicetree/bindings/sound/fsl,asrc.txt > > @@ -51,6 +51,11 @@ Optional properties: > > will be in use as default. Otherwise, the big endian > > mode will be in use for all the device registers. > > > > + - fsl,asrc-format : Defines a mutual sample format used by DPCM Back > > + Ends, which can replace the fsl,asrc-width. > > + The value is SNDRV_PCM_FORMAT_S16_LE, or > > + SNDRV_PCM_FORMAT_S24_LE > > I am still holding the concern at the DT binding of this format, > as it uses values from ASoC header file instead of a dt-binding > header file -- not sure if we can do this. Let's wait for Rob's > comments. I assume those are an ABI as well, so it's okay to copy them unless we already have some format definitions for DT. But it does need to be copy in a header under include/dt-bindings/. Rob