From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/3] Makefile: don't hang the build if there are no file lists
Date: Fri, 20 Mar 2020 22:10:26 +0100 [thread overview]
Message-ID: <20200320221026.40dc06ab@windsurf.home> (raw)
In-Reply-To: <20200318214908.GB10025@scaer>
On Wed, 18 Mar 2020 22:49:08 +0100
"Yann E. MORIN" <yann.morin.1998@free.fr> wrote:
> I would like to suggest an alternative, that guarantees the files are
> created, even if empty:
>
> $(if $(STAGING_DIR_FILES_LISTS), \
> cat $(STAGING_DIR_FILES_LISTS)) >$(BUILD_DIR)/packages-file-list-staging.txt
>
> Notice how the redirection is outside the conditional, so that if there
> is no file, the commadn will be:
>
> > $(BUILD_DIR)/packages-file-list-staging.txt
>
> Which will create an empty file.
>
> Thoughts? Shall I do that when applying the series or will you want to
> respin?
What you suggest sounds good to me. Feel free to tweak that when
applying. Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2020-03-20 21:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-18 15:58 [Buildroot] [PATCH 1/3] Makefile: don't hang the build if there are no file lists Thomas De Schampheleire
2020-03-18 15:58 ` [Buildroot] [PATCH 2/3] Makefile: fix package file list if FOO_SUBDIR is set Thomas De Schampheleire
2020-03-28 7:39 ` Peter Korsgaard
2020-03-28 8:58 ` Thomas De Schampheleire
2020-03-28 11:06 ` Peter Korsgaard
2020-03-18 15:58 ` [Buildroot] [PATCH 3/3] Makefile: assemble package file lists before calling post-build scripts Thomas De Schampheleire
2020-03-28 7:39 ` Peter Korsgaard
2020-03-18 21:49 ` [Buildroot] [PATCH 1/3] Makefile: don't hang the build if there are no file lists Yann E. MORIN
2020-03-20 21:10 ` Thomas Petazzoni [this message]
2020-03-20 21:29 ` Yann E. MORIN
2020-03-28 7:37 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200320221026.40dc06ab@windsurf.home \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.