All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [pkg-luarocks 1/6] pkg-luarocks: remove LUAROCKS_RUN_ENV
Date: Fri, 20 Mar 2020 22:40:05 +0100	[thread overview]
Message-ID: <20200320224005.021d5754@windsurf.home> (raw)
In-Reply-To: <CAB0FRssKPcjBCcCiun6azNDMYh4UYy4ypBmbDkDqwKDsAAX49Q@mail.gmail.com>

Hello Fran?ois,

I am getting back to this series, trying to get it finally merged.

On Wed, 18 Sep 2019 20:18:18 +0200
Fran?ois Perrad <francois.perrad@gadz.org> wrote:

> Le mer. 18 sept. 2019 ? 09:31, Thomas Petazzoni <
> thomas.petazzoni at bootlin.com> a ?crit :  
> 
> > On Wed, 18 Sep 2019 08:19:10 +0200
> > Francois Perrad <fperrad@gmail.com> wrote:
> >  
> > > Signed-off-by: Francois Perrad <francois.perrad@gadz.org>  
> >
> > This requires more details in the commit log. Why can you do this ?
> >
> >  
> just a preliminary step,
> could be squashed with the next commit 2/6

So, preliminary steps are good to have separately if possible. But you
still didn't explain how this patch works. How is it possible to simply
delete LUAROCKS_RUN_ENV ? The variables passed in LUAROCKS_RUN_ENV are
not needed ? If they are not needed, why do they exist in the first
place ?

We really need a better explanation.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

      reply	other threads:[~2020-03-20 21:40 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-18  6:19 [Buildroot] [pkg-luarocks 1/6] pkg-luarocks: remove LUAROCKS_RUN_ENV Francois Perrad
2019-09-18  6:19 ` [Buildroot] [pkg-luarocks 2/6] pkg-luarocks: refactor infra Francois Perrad
2019-09-18  6:19 ` [Buildroot] [pkg-luarocks 3/6] pkg-luarocks: regen packages with external dependencies Francois Perrad
2019-09-18  7:35   ` Thomas Petazzoni
2019-09-18 18:19     ` François Perrad
2019-09-18 19:16       ` Thomas Petazzoni
2019-09-19 16:38         ` François Perrad
2019-09-19 19:11           ` Thomas Petazzoni
2020-03-20 21:41           ` Thomas Petazzoni
2019-09-18  6:19 ` [Buildroot] [pkg-luarocks 4/6] pkg-luarocks: add support of host-luarocks-package Francois Perrad
2020-03-20 21:48   ` Thomas Petazzoni
2019-09-18  6:19 ` [Buildroot] [pkg-luarocks 5/6] package/lua: allows to load native modules from host-lua Francois Perrad
2019-09-18  6:19 ` [Buildroot] [pkg-luarocks 6/6] package/lua: allows host-lua to find installed modules Francois Perrad
2019-09-18  7:31 ` [Buildroot] [pkg-luarocks 1/6] pkg-luarocks: remove LUAROCKS_RUN_ENV Thomas Petazzoni
2019-09-18 18:18   ` François Perrad
2020-03-20 21:40     ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200320224005.021d5754@windsurf.home \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.