All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Gokce Kuler <gokcekuler@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [PATCH] staging: ks7010: rearrange line exceeding 80 characters
Date: Sat, 21 Mar 2020 10:32:30 +0100	[thread overview]
Message-ID: <20200321093230.GA917692@kroah.com> (raw)
In-Reply-To: <20200321002259.GA12633@siyah2>

On Sat, Mar 21, 2020 at 03:22:59AM +0300, Gokce Kuler wrote:
> Moved to the bottom line after == operator for it exceeds 80 character
> 
> Signed-off-by: Gokce Kuler <gokcekuler@gmail.com>
> ---
>  drivers/staging/ks7010/ks_hostif.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c
> index 2666f9e..7ed8300 100644
> --- a/drivers/staging/ks7010/ks_hostif.c
> +++ b/drivers/staging/ks7010/ks_hostif.c
> @@ -1953,8 +1953,10 @@ static void hostif_sme_power_mgmt_set(struct ks_wlan_private *priv)
>  		mode = (priv->reg.operation_mode == MODE_INFRASTRUCTURE) ?
>  			POWER_SAVE : POWER_ACTIVE;
>  		wake_up = 0;
> -		receive_dtims = (priv->reg.operation_mode == MODE_INFRASTRUCTURE &&
> -				 priv->reg.power_mgmt == POWER_MGMT_SAVE2);
> +		receive_dtims = (priv->reg.operation_mode ==
> +			       	 MODE_INFRASTRUCTURE &&
> +				 priv->reg.power_mgmt ==
> +				 POWER_MGMT_SAVE2);

This is now much harder to read and understand, so I woudl just leave
the original as-is.

thanks,

greg k-h


      reply	other threads:[~2020-03-21  9:32 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-21  0:22 [PATCH] staging: ks7010: rearrange line exceeding 80 characters Gokce Kuler
2020-03-21  9:32 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200321093230.GA917692@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=gokcekuler@gmail.com \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.