From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/localedef: add missing dependeny on host-gawk
Date: Sat, 21 Mar 2020 17:38:38 +0100 [thread overview]
Message-ID: <20200321163838.GC4290@scaer> (raw)
In-Reply-To: <20200317220204.40127-1-romain.naour@gmail.com>
Romain, All,
On 2020-03-17 23:02 +0100, Romain Naour spake thusly:
> While reviewing the patch [1], we noticed that host-gawk dependency
> was missing. I may trigger an issue if gawk is missing on the host
> since it's a "critical tool" [2].
> Indeed, localedef package is actually glibc sources that check gawk
> host binary.
> host-gawk is listed in glibc package dependency [3], so add it now.
>
> [1] af90a104c06542a1bf5545eaf9b9c7beb7176e80
> [2] https://sourceware.org/git/?p=glibc.git;a=blob;f=configure.ac;h=49b900c1ed68fa4dd1dadca809ceb6e8b237a89c;hb=9ea3686266dca3f004ba874745a4087a89682617#l1021
> [3] https://git.buildroot.net/buildroot/tree/package/glibc/glibc.mk?h=2020.02#n38
>
> Signed-off-by: Romain Naour <romain.naour@gmail.com>
> Cc: Yann E. MORIN <yann.morin.1998@free.fr>
Applied to master, thanks.
Regards,
Yann E. MORIN.
> ---
> package/localedef/localedef.mk | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/package/localedef/localedef.mk b/package/localedef/localedef.mk
> index 3e22f68039..1093e106fa 100644
> --- a/package/localedef/localedef.mk
> +++ b/package/localedef/localedef.mk
> @@ -14,7 +14,8 @@ HOST_LOCALEDEF_DL_SUBDIR = glibc
>
> HOST_LOCALEDEF_DEPENDENCIES = \
> $(BR2_MAKE_HOST_DEPENDENCY) \
> - host-bison
> + host-bison \
> + host-gawk
>
> HOST_LOCALEDEF_CONF_ENV += ac_cv_prog_MAKE="$(BR2_MAKE)"
>
> --
> 2.24.1
>
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2020-03-21 16:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-17 22:02 [Buildroot] [PATCH] package/localedef: add missing dependeny on host-gawk Romain Naour
2020-03-21 16:38 ` Yann E. MORIN [this message]
2020-04-07 6:28 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200321163838.GC4290@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.