From: Wolfram Sang <wsa@the-dreams.de>
To: Sergey.Semin@baikalelectronics.ru
Cc: Jarkko Nikula <jarkko.nikula@linux.intel.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Serge Semin <fancer.lancer@gmail.com>,
Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Paul Burton <paulburton@kernel.org>,
Ralf Baechle <ralf@linux-mips.org>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/6] i2c: designware: Add Baikal-T1 SoC I2C controller support
Date: Sat, 21 Mar 2020 19:33:49 +0100 [thread overview]
Message-ID: <20200321183349.GC5632@ninjato> (raw)
In-Reply-To: <20200306132348.71E638030793@mail.baikalelectronics.ru>
[-- Attachment #1: Type: text/plain, Size: 992 bytes --]
On Fri, Mar 06, 2020 at 04:19:58PM +0300, Sergey.Semin@baikalelectronics.ru wrote:
> From: Serge Semin <Sergey.Semin@baikalelectronics.ru>
>
> A third I2C controller embedded into the Baikal-T1 SoC is also fully
> based on the DW APB I2C core, but its registers are indirectly
> accessible via "command/data in/data out" trio. There is no difference
> other than that. So in order to have that controller supported by the
> common DW APB I2C driver we only need to introduce a new flag
> ACCESS_INDIRECT and use the access-registers to reach the I2C controller
> normal registers space in the dw_readl/dw_writel methods. Currently this
> flag is only enabled for the controllers with "be,bt1-i2c" compatible
> string.
>
> Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
> Signed-off-by: Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>
Patches 2,3, and 6 have comments which should be addressed. Patches 4+5
can be dropped when sending next version.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-03-21 18:33 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200306131955.12806-1-Sergey.Semin@baikalelectronics.ru>
2020-03-06 13:19 ` [PATCH 1/6] scripts/dtc: check: Add additional i2c reg flags support Sergey.Semin
[not found] ` <20200306131955.12806-1-Sergey.Semin-UN2wsyeM1qLJ45LvJ/SUn8gurn75+9Lz@public.gmane.org>
2020-03-06 13:19 ` [PATCH 2/6] dt-bindings: i2c: Replace DW I2C legacy bindings with YAML-based one Sergey.Semin-UN2wsyeM1qLJ45LvJ/SUn8gurn75+9Lz
2020-03-06 13:19 ` Sergey.Semin
[not found] ` <20200306132011.66A7A80307C4-wa7pjkrhtJ0iPEH9HxOKe7DSMK2IXMYWh13vi7wywA4@public.gmane.org>
2020-03-12 21:43 ` Rob Herring
2020-03-12 21:43 ` Rob Herring
2020-03-25 20:49 ` Sergey Semin
2020-03-25 20:49 ` Sergey Semin
2020-03-06 13:19 ` [PATCH 3/6] dt-bindings: i2c: dw: Add Baikal-T1 SoC I2C controller Sergey.Semin-UN2wsyeM1qLJ45LvJ/SUn8gurn75+9Lz
2020-03-06 13:19 ` Sergey.Semin
2020-03-12 21:43 ` Rob Herring
2020-03-12 21:43 ` Rob Herring
2020-03-25 21:09 ` Sergey Semin
2020-03-25 21:09 ` Sergey Semin
2020-03-06 13:19 ` [PATCH 4/6] i2c: designware: Detect the FIFO size in the common code Sergey.Semin
2020-03-06 13:19 ` Sergey.Semin
2020-03-06 15:01 ` Andy Shevchenko
2020-03-12 14:50 ` Jarkko Nikula
2020-03-21 18:32 ` Wolfram Sang
2020-03-06 13:19 ` [PATCH 5/6] i2c: designware: Discard i2c_dw_read_comp_param() function Sergey.Semin
2020-03-06 13:19 ` Sergey.Semin
2020-03-12 14:50 ` Jarkko Nikula
2020-03-21 18:32 ` Wolfram Sang
2020-03-06 13:19 ` [PATCH 6/6] i2c: designware: Add Baikal-T1 SoC I2C controller support Sergey.Semin
2020-03-06 13:19 ` Sergey.Semin
2020-03-06 13:51 ` Andy Shevchenko
2020-03-21 18:33 ` Wolfram Sang [this message]
2020-03-25 18:21 ` Sergey Semin
2020-03-25 18:21 ` Sergey Semin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200321183349.GC5632@ninjato \
--to=wsa@the-dreams.de \
--cc=Alexey.Malahov@baikalelectronics.ru \
--cc=Sergey.Semin@baikalelectronics.ru \
--cc=andriy.shevchenko@linux.intel.com \
--cc=fancer.lancer@gmail.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=paulburton@kernel.org \
--cc=ralf@linux-mips.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.