From: Soumyajit Deb <debsoumyajit100@gmail.com>
To: gregkh@linuxfoundation.org
Cc: perex@perex.cz, outreachy-kernel@googlegroups.com
Subject: [PATCH] staging: hp100: Add space around + operator and remove space around pointers
Date: Sun, 22 Mar 2020 19:14:47 +0530 [thread overview]
Message-ID: <20200322134439.GA30399@ubuntu> (raw)
Add space around + operator and remove space after * in pointer
declaration to improve code readability
Reported by checkpatch.pl
Signed-off-by: Soumyajit Deb <debsoumyajit100@gmail.com>
---
drivers/staging/hp/hp100.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/hp/hp100.c b/drivers/staging/hp/hp100.c
index b89c4dcf53f5..2cf1104cd2dd 100644
--- a/drivers/staging/hp/hp100.c
+++ b/drivers/staging/hp/hp100.c
@@ -119,7 +119,7 @@
#define HP100_REGION_SIZE 0x20 /* for ioports */
#define HP100_SIG_LEN 8 /* same as EISA_SIG_LEN */
-#define HP100_MAX_PACKET_SIZE (1536+4)
+#define HP100_MAX_PACKET_SIZE (1536 + 4)
#define HP100_MIN_PACKET_SIZE 60
#ifndef HP100_DEFAULT_RX_RATIO
@@ -246,11 +246,11 @@ static void hp100_BM_shutdown(struct net_device *dev);
static void hp100_mmuinit(struct net_device *dev);
static void hp100_init_pdls(struct net_device *dev);
static int hp100_init_rxpdl(struct net_device *dev,
- register hp100_ring_t * ringptr,
- register u_int * pdlptr);
+ register hp100_ring_t *ringptr,
+ register u_int *pdlptr);
static int hp100_init_txpdl(struct net_device *dev,
- register hp100_ring_t * ringptr,
- register u_int * pdlptr);
+ register hp100_ring_t *ringptr,
+ register u_int *pdlptr);
static void hp100_rxfill(struct net_device *dev);
static void hp100_hwinit(struct net_device *dev);
static void hp100_clean_txring(struct net_device *dev);
@@ -264,7 +264,7 @@ static void hp100_RegisterDump(struct net_device *dev);
* because it was properly DMA allocated via pci_alloc_consistent(),
* so we just need to "retrieve" the original mapping to bus/phys/dma
* address - Jean II */
-static inline dma_addr_t virt_to_whatever(struct net_device *dev, u32 * ptr)
+static inline dma_addr_t virt_to_whatever(struct net_device *dev, u32 *ptr)
{
struct hp100_private *lp = netdev_priv(dev);
return ((u_long) ptr) + lp->whatever_offset;
--
2.17.1
next reply other threads:[~2020-03-22 13:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-22 13:44 Soumyajit Deb [this message]
2020-03-22 13:54 ` [Outreachy kernel] [PATCH] staging: hp100: Add space around + operator and remove space around pointers Julia Lawall
-- strict thread matches above, loose matches on Subject: below --
2020-03-22 13:48 Soumyajit Deb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200322134439.GA30399@ubuntu \
--to=debsoumyajit100@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=outreachy-kernel@googlegroups.com \
--cc=perex@perex.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.