Re: [PATCH] Staging: speakup: Use pr_warn() defined in <linux/printk.h>.

[Samuel Thibault <samuel.thibault@ens-lyon.org>]

Sam Muhammed, le dim. 22 mars 2020 10:33:22 -0400, a ecrit:
> Dropping a user-defined pr_warn() and using the kernel
> message printing functions implemented in <linux/printk.h>.
> 
> Since both have the same functionality, using the standard
> kernel functions is better.
> 
> Signed-off-by: Sam Muhammed <jane.pnx9@gmail.com>

Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>

Thanks!

> ---
>  drivers/staging/speakup/spk_priv.h | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/speakup/spk_priv.h b/drivers/staging/speakup/spk_priv.h
> index ac6a74883af4..c75b40838794 100644
> --- a/drivers/staging/speakup/spk_priv.h
> +++ b/drivers/staging/speakup/spk_priv.h
> @@ -11,13 +11,11 @@
>  #ifndef _SPEAKUP_PRIVATE_H
>  #define _SPEAKUP_PRIVATE_H
> 
> +#include <linux/printk.h>
> +
>  #include "spk_types.h"
>  #include "spk_priv_keyinfo.h"
> 
> -#ifndef pr_warn
> -#define pr_warn(fmt, arg...) printk(KERN_WARNING fmt, ##arg)
> -#endif
> -
>  #define V_LAST_VAR { MAXVARS }
>  #define SPACE 0x20
>  #define SYNTH_CHECK 20030716 /* today's date ought to do for check value */
> ---
> 2.20.1
>