From: Jonathan Cameron <jic23@kernel.org>
To: Eugene Zalkonnikov <ez@norphonic.com>
Cc: Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
"development@norphonic.com" <development@norphonic.com>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH v6 2/2] Device tree bindings for TI HDC20x0 humidity and temperature sensors
Date: Sun, 22 Mar 2020 16:03:10 +0000 [thread overview]
Message-ID: <20200322160310.67365997@archlinux> (raw)
In-Reply-To: <1C2C8CD5-4BF0-40AE-932A-4AD506664B9D@norphonic.com>
On Tue, 17 Mar 2020 20:09:48 +0000
Eugene Zalkonnikov <ez@norphonic.com> wrote:
> Device tree bindings for the HDC2010/2080 driver.
>
> Signed-off-by: Eugene Zaikonnikov <eugene.zaikonnikov@norphonic.com>
Hi Eugene
A few minor things inline
Jonathan
>
> diff -uprN linux-5.3.8/Documentation/devicetree/bindings/iio/humidity/ti,hdc2010.yaml linux-5.3.8_docs/Documentation/devicetree/bindings/iio/humidity/ti,hdc2010.yaml
> --- linux-5.3.8/Documentation/devicetree/bindings/iio/humidity/ti,hdc2010.yaml 1970-01-01 01:00:00.000000000 +0100
> +++ linux-5.3.8_docs/Documentation/devicetree/bindings/iio/humidity/ti,hdc2010.yaml 2020-02-12 14:28:42.562903814 +0100
> @@ -0,0 +1,43 @@
> +# SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/humidity/hdc2010.yaml#
As Rob's bot pointed out... ti,hdc2010.yaml preferred.
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: HDC2010/HDC2080 humidity and temperature iio sensors
> +
> +maintainers:
> + - Eugene Zaikonnikov <eugene.zaikonnikov@norophonic.com>
> +
> +description: |
> + Relative humidity and tempereature sensors on I2C bus
> +
> + Datasheets are available at:
> + http://www.ti.com/product/HDC2010/datasheet
> + http://www.ti.com/product/HDC2080/datasheet
> +
> +properties:
> + compatible:
> + enum:
> + - ti,hdc2010
> + - ti,hdc2080
> +
> + vddd-supply:
ddd rather than dd?
> + description:
> + digital voltage regulator (see regulator/regulator.txt)
For main supply probably don't need to bother with description.
> + maxItems: 1
> +
> +required:
> + - compatible
> +
> +examples:
> + - |
> + i2c0 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + hdc200x@40 {
Naming should be 'generic'.
humidity@40 {
Is probably appropriate though not on the explicit list in the devicetree
spec yet.
> + compatible = "ti,hdc2010";
> + reg = <0x40>;
> + };
> + };
>
next prev parent reply other threads:[~2020-03-22 16:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-17 20:06 [PATCH v6 1/2] Driver for TI HDC20x0 humidity and temperature sensors Eugene Zalkonnikov
2020-03-17 20:09 ` [PATCH v6 2/2] Device tree bindings " Eugene Zalkonnikov
2020-03-18 22:59 ` Rob Herring
2020-03-22 16:03 ` Jonathan Cameron [this message]
2020-03-22 16:17 ` [PATCH v6 1/2] Driver " Jonathan Cameron
2020-03-23 14:39 ` Eugene Zalkonnikov
2020-03-28 15:21 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200322160310.67365997@archlinux \
--to=jic23@kernel.org \
--cc=development@norphonic.com \
--cc=devicetree@vger.kernel.org \
--cc=ez@norphonic.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=mark.rutland@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.