From: Wolfram Sang <wsa@the-dreams.de>
To: Chuhong Yuan <hslester96@gmail.com>,
Seth Heasley <seth.heasley@intel.com>,
Neil Horman <nhorman@tuxdriver.com>
Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c: ismt: Add missed pci_release_region
Date: Sun, 22 Mar 2020 17:08:10 +0100 [thread overview]
Message-ID: <20200322160810.GE1091@ninjato> (raw)
In-Reply-To: <20191109075435.29871-1-hslester96@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 891 bytes --]
On Sat, Nov 09, 2019 at 03:54:35PM +0800, Chuhong Yuan wrote:
> ismt_remove forgets to call pci_release_region when remove.
> Add the call to fix it.
>
> Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
Chuhong Yuan, your To-Header is broken, so you never got a response.
Adding the maintainers to CC.
> ---
> drivers/i2c/busses/i2c-ismt.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/i2c/busses/i2c-ismt.c b/drivers/i2c/busses/i2c-ismt.c
> index 2f95e25a10f7..c393e629cac3 100644
> --- a/drivers/i2c/busses/i2c-ismt.c
> +++ b/drivers/i2c/busses/i2c-ismt.c
> @@ -943,6 +943,8 @@ static void ismt_remove(struct pci_dev *pdev)
> struct ismt_priv *priv = pci_get_drvdata(pdev);
>
> i2c_del_adapter(&priv->adapter);
> +
> + pci_release_region(pdev, SMBBAR);
> }
>
> static struct pci_driver ismt_driver = {
> --
> 2.23.0
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2020-03-22 16:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-09 7:54 [PATCH] i2c: ismt: Add missed pci_release_region Chuhong Yuan
2019-11-09 7:54 ` Chuhong Yuan
2020-03-22 16:08 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200322160810.GE1091@ninjato \
--to=wsa@the-dreams.de \
--cc=hslester96@gmail.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=seth.heasley@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.