From: Jonathan Cameron <jic23@kernel.org>
To: Alexandru Lazar <alazar@startmail.com>
Cc: "Ardelean, Alexandru" <alexandru.Ardelean@analog.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"knaack.h@gmx.de" <knaack.h@gmx.de>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"pmeerw@pmeerw.net" <pmeerw@pmeerw.net>,
"lars@metafoo.de" <lars@metafoo.de>
Subject: Re: [PATCH v4 1/2] dt-bindings: iio: adc: Add MAX1241 device tree bindings in documentation
Date: Sun, 22 Mar 2020 16:57:30 +0000 [thread overview]
Message-ID: <20200322165730.11fa376a@archlinux> (raw)
In-Reply-To: <20200322160604.GA222611@leena.republic>
On Sun, 22 Mar 2020 18:06:04 +0200
Alexandru Lazar <alazar@startmail.com> wrote:
> > You'd be surprised how often this gets added to drivers precisely because
> > people will put it on a controllable supply. It may well not have it's own
> > supply but it may share one with a bunch of other external chips and
> > all of them need to use the regulator framework controls to make sure it's
> > only disabled when they are all suspended etc.
>
> I figured it might be something like this :-). I've added the vdd-supply
> binding in v5.
>
> If this isn't something that can be easily handled in the core, do you
> think we can document it somewhere as a convention/common idiom?
> (Assuming it's not already documented, of course). It seems like it's
> something that all IIO devices would need. I can do the writing part.
Hmm. We could do with a sort of 'things you'd normally find in a driver'
document. We don't have such a document, but interesting to think about
what would be in it... Perhaps a 'best practice' document would
be a better way of putting it. I don't really want to see a huge
number of patches adding regulators to drivers that don't have them already
for example. Clearly no one needed them yet :)
If you want to take a stab at such a document that would be great.
Jonathan
>
> Thanks,
> Alex
next prev parent reply other threads:[~2020-03-22 16:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-20 15:01 [PATCH v4 0/2] Maxim MAX1241 driver Alexandru Lazar
2020-03-20 15:01 ` [PATCH v4 1/2] dt-bindings: iio: adc: Add MAX1241 device tree bindings in documentation Alexandru Lazar
2020-03-21 17:34 ` Jonathan Cameron
2020-03-21 19:35 ` Alexandru Lazar
2020-03-22 9:02 ` Ardelean, Alexandru
2020-03-22 9:53 ` Alexandru Lazar
2020-03-22 15:27 ` Jonathan Cameron
2020-03-22 16:06 ` Alexandru Lazar
2020-03-22 16:57 ` Jonathan Cameron [this message]
2020-03-22 15:25 ` Jonathan Cameron
2020-03-30 23:39 ` Rob Herring
2020-03-20 15:01 ` [PATCH v4 2/2] iio: adc: Add MAX1241 driver Alexandru Lazar
2020-03-21 18:00 ` Jonathan Cameron
2020-03-21 21:56 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200322165730.11fa376a@archlinux \
--to=jic23@kernel.org \
--cc=alazar@startmail.com \
--cc=alexandru.Ardelean@analog.com \
--cc=devicetree@vger.kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.