From: Jonathan Cameron <jic23@kernel.org>
To: Brian Masney <masneyb@onstation.org>
Cc: Takashi Iwai <tiwai@suse.de>, linux-iio@vger.kernel.org
Subject: Re: [PATCH v2 2/2] iio: tsl2772: Use scnprintf() for avoiding potential buffer overflow
Date: Sun, 22 Mar 2020 18:08:42 +0000 [thread overview]
Message-ID: <20200322180842.3a796160@archlinux> (raw)
In-Reply-To: <20200316162026.GB1526@onstation.org>
On Mon, 16 Mar 2020 12:20:26 -0400
Brian Masney <masneyb@onstation.org> wrote:
> On Mon, Mar 16, 2020 at 01:49:41PM +0100, Takashi Iwai wrote:
> > snprintf() is a hard-to-use function, it's especially difficult to use
> > it for concatenating substrings in a buffer with a limited size.
> > Since snprintf() returns the would-be-output size, not the actual
> > size, the subsequent use of snprintf() may go beyond the given limit
> > easily. Although the current code doesn't actually overflow the
> > buffer, it's an incorrect usage.
> >
> > This patch replaces such snprintf() calls with a safer version,
> > scnprintf().
> >
> > Also this fixes the incorrect argument of the buffer limit size passed
> > to snprintf(), too. The size has to be decremented for the remaining
> > length.
> >
> > Signed-off-by: Takashi Iwai <tiwai@suse.de>
>
> Reviewed-by: Brian Masney <masneyb@onstation.org>
Applied. Thanks for sorting this out.
Jonathan
prev parent reply other threads:[~2020-03-22 18:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-16 12:49 [PATCH v2 0/2] iio: Use scnprintf() for avoiding potential buffer overflow Takashi Iwai
2020-03-16 12:49 ` [PATCH v2 1/2] iio: core: " Takashi Iwai
2020-03-16 16:19 ` Brian Masney
2020-03-22 18:06 ` Jonathan Cameron
2020-03-16 12:49 ` [PATCH v2 2/2] iio: tsl2772: " Takashi Iwai
2020-03-16 16:20 ` Brian Masney
2020-03-22 18:08 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200322180842.3a796160@archlinux \
--to=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=masneyb@onstation.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.